GNOME Bugzilla – Bug 326447
check that all elements in -base pass queries they can't handle upstream
Last modified: 2006-02-01 12:02:11 UTC
Make sure elements in -base pass queries they cannot handle upstream with res = gst_pad_default_query (pad, query) or something. Makes the SEEKING query much more useful (for example).
Things I saw in -base that look a little sketchy: audiotestsrc, which has a different handling of the default: case than videotestsrc, but it's a basesrc implementation ? adder, seems to be broken (really need some adder test cases but that's another issue) vorbisdec, both sink and src query vorbisenc, same theoradec, same oggdemux, ogg_pad_src_query ogmparse, parse_sink_query That's from an exhaustive search while my dapper was upgrading :-)
2006-02-01 Tim-Philipp Müller <tim at centricular dot net> * ext/ogg/gstoggdemux.c: (gst_ogg_pad_query_types), (gst_ogg_pad_src_query): * ext/ogg/gstogmparse.c: (gst_ogm_parse_sink_query): * ext/theora/theoradec.c: (theora_dec_src_query), (theora_dec_sink_query): * ext/vorbis/vorbisdec.c: (vorbis_dec_src_query), (vorbis_dec_sink_query): * ext/vorbis/vorbisenc.c: (gst_vorbisenc_src_query), (gst_vorbisenc_sink_query): * gst/adder/gstadder.c: (gst_adder_query): Pass unhandled queries upstream instead of just dropping them (#326447). Also, fix supported query types list for some elements. 2006-02-01 Tim-Philipp Müller <tim at centricular dot net> * gst-libs/gst/cdda/gstcddabasesrc.c: (gst_cdda_base_src_query), (gst_cdda_base_src_handle_event): * gst/audiotestsrc/gstaudiotestsrc.c: (gst_audio_test_src_query): Pass unhandled queries to the parent class's query function.