Bug 326189 – modem applet sometimes crash when logout

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 326189 - modem applet sometimes crash when logout


Summary:	modem applet sometimes crash when logout


Status:	RESOLVED FIXED

Product:	gnome-applets
Classification:	Other
Component:	modemlights
Version:	2.13.x
Hardware:	Other Linux

Importance:	High normal
Target Milestone:	2.14
Assigned To:	gnome-applets Maintainers
QA Contact:	gnome-applets Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2006-01-08 11:04 UTC by Sebastien Bacher
Modified:	2010-01-24 01:06 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
unregister the tooltip update (361 bytes, patch) 2006-01-08 11:22 UTC, Sebastien Bacher	committed	Details \| Review

Description Sebastien Bacher 2006-01-08 11:04:22 UTC

That bug has been described on http://bugzilla.ubuntu.com/show_bug.cgi?id=21847

"Sometimes, gnome modem applet crash when i loged out of my gnome
...
> Thanks for your bug. What version of Ubuntu do you use? How do you notice it
crashes? Could you get a backtrace of the crash (https://wiki.ubuntu.com/DebuggingProgramCrash)?
...
i have another bt:
(gdb) run
Starting program: /usr/lib/gnome-applets/modem_applet
[Thread debugging using libthread_db enabled]
[New Thread -1223547200 (LWP 5668)]
// HERE I LOGGED OUT
(modem_applet:5668): GLib-GObject-WARNING **: instance of invalid
non-instantiatable type `(null)'

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread -1223547200 (LWP 5668)]
update_tooltip (applet=0x80c08a8) at modem-applet.c:728
728     modem-applet.c: není souborem ani adresářem. (this means no such file or
directory)
        in modem-applet.c
(gdb) thread apply all bt

+ Trace 65035

Thread 1 (Thread -1223547200 (LWP 5668))

#0 update_tooltip
at modem-applet.c line 728
#1 g_main_context_wakeup
from /usr/lib/libglib-2.0.so.0
#2 g_main_context_dispatch
from /usr/lib/libglib-2.0.so.0
#3 g_main_context_check
from /usr/lib/libglib-2.0.so.0
#4 g_main_context_iteration
from /usr/lib/libglib-2.0.so.0
#5 gtk_main_iteration
from /usr/lib/libgtk-x11-2.0.so.0
#6 dispatch_directives
at modem-applet.c line 499
#7 g_main_context_wakeup
from /usr/lib/libglib-2.0.so.0
#8 g_main_context_dispatch
from /usr/lib/libglib-2.0.so.0
#9 g_main_context_check
from /usr/lib/libglib-2.0.so.0
#10 g_main_loop_run
from /usr/lib/libglib-2.0.so.0
#11 bonobo_main
from /usr/lib/libbonobo-2.so.0
#12 bonobo_generic_factory_main_timeout
from /usr/lib/libbonobo-2.so.0
#13 bonobo_generic_factory_main
from /usr/lib/libbonobo-2.so.0
#14 panel_applet_factory_main_closure
from /usr/lib/libpanel-applet-2.so.0
#15 panel_applet_factory_main
from /usr/lib/libpanel-applet-2.so.0
#16 main
at modem-applet.c line 1126

Comment 1 Sebastien Bacher 2006-01-08 11:16:22 UTC

I bet that update_tooltip is called after having the applet freed, g_source_remove () should be used on priv->tooltip_id ()

Comment 2 Sebastien Bacher 2006-01-08 11:22:46 UTC

Created attachment 56960 [details] [review]
unregister the tooltip update

I don't have a modem on my box and it doesn't crash for me but that should fix the issue, we unregister the tooltip update before the applet

Comment 3 Danielle Madeley 2006-01-08 15:31:36 UTC

Looks good. Put it in HEAD. Thanks, Seb.

Comment 4 Sebastien Bacher 2006-01-08 18:21:02 UTC

Fix commited:

2006-01-08  Sebastien Bacher  <seb128@debian.org>

	* modem-applet.c: (shutdown_backend): stop updating the tooltip
	when the applet is removed, fix a crasher (Closes: #326189)