GNOME Bugzilla – Bug 325945
Delete dialog shows a picture of a trashcan.
Last modified: 2009-10-07 15:56:39 UTC
The delete dialog shows a picture of a trashcan. That suggests that the file will be available in the trash to recover if the user changes his mind. That behavior is of course only available if the user selects "Move to Trash". Other information:
Created attachment 56839 [details] Dialog box.
I don't know if these kinds of reports are valuable or just create noise. I was inspired to file it by the recent post[1] on planet.gnome.org from Federico where several visual inconsistencies where pointed out. Depending how this bug report (my first to Gnome) goes, I have about 10 other small things that I think might be confusing to average users. 1) http://primates.ximian.com/~federico/news-2006-01.html#smoke-testing-gnome-2-13-4 Regards, Gabriel
The bug seems relevant IMHO... The icon is a reminder for the functionnality... having a trashcan while it will never reach it is a broken comportment for me...
Yes, this is relevant. Marking priority as high since it can cause data loss.
Created attachment 56915 [details] [review] Proposed patch Also submitted for review: http://mail.gnome.org/archives/nautilus-list/2006-January/msg00033.html
IHMO the really issue here is the bad icon metaphor for gtk-delete. So I think is better: 1. Change "Move to Trash" menu entry to use a trash icon and "Delete" menu entry to use a delete icon 2. Change the gtk-delete stock icon in GTK+ (or in gnome-icon-theme) to use a non-trash metaphor. See the attached screenshot
Created attachment 57199 [details] Delete confirm dialog using a non-trash icon for delete action Icons from Tango project :-)
Created attachment 57200 [details] Menu entries for move_to_trash and delete actions using well fitted icons Maybe the move_to_trash entry could use the trash-full icon.
Created attachment 57933 [details] [review] Use trash icon with "Move to trash" and GTK_STOCK_DELETE with "delete" A quick and dirty, but working, patch to use "gnome-fs-trash-emtpy" icon for "Move to Trash" menu entries and GTK_STOCK_DELETE for "Delete" menu entries and button in confirmation alert (I should check for other buttons). Of course delete confirmation alert still shows a trashcan, but this is a bug to fix in gnome-icon-theme and/or GTK+ stock icons. Honestly I don't like too much this solution. IMHO we should direclty use new named icons 'user-trash' (or user-trash-full) for "Move to Trash" items and 'edit-delete' for "Delete" items. Can I commit something?
Created attachment 57934 [details] A template for edit-delete icon Alex, what do you think about something like this for edit-delete action?
I can't set it, but this bug should depend on bug # 169451 (no trash for edit-delete). When this bug will bu closed, we can simply keep GTK_STOCK_DELETE for all "Delete" action (direct Delete and Delete from trash) and use "user-trash-full" named icon (or NULL) for "Move to Trash" action
Created attachment 69496 [details] [review] Updated patch to use named icon for "move to trash" and GTK_STOCK_DELETE for delete action Updated patch against current code. Try it using current Tango as icon theme. Unfortunately not complete. The "Delete from Trash" action (Edit menu when browsing the trash:// locations) is still using the trashcan as icon after applying this patch. I need to investigate.
What about this. This is still valid now with gnome-2.20 Thanks a lot
Still there in 2.21.
I just fixed all the menu items, which obsoletes attachment 69496 [details] [review]: http://svn.gnome.org/viewvc/nautilus/trunk/ We had to set the "icon-name" rather than the "stock-id" of the actions. I am also not sure what to do about the "Empty Trash" dialog, which still has a "Delete" icon and button: On the one hand it is inconsistent with the "Empty Trash" action, but on the other hand it is totally consistent with the "Delete" action (it emphasizes the two-step deletion from trash, which is also shown when deleting single items from trash), and the icon looks nice.
This is an icon theme bug. If it is true that showing a trash can is a confusing visual concept for "delete" then the delete icon should not be a trash can. Working around the broken semantics in Nautilus is very silly.
-> gnome-icon-theme The new icon theme uses another icon, so I guess this can be closed as OBSOLETE.