GNOME Bugzilla – Bug 325652
many plugins don't pass unhandled queries upstream
Last modified: 2006-01-10 11:53:38 UTC
Please describe the problem: gstmad doesn't pass the query upstream as it should. (At least in playbin!) Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
The same can be said of gstid3tag. It doesn't pass query upstream.
Created attachment 56771 [details] [review] This patch should fix this kind of problem for all plugins in gst-plugins-ugly
Thanks, fixed in CVS: 2006-01-10 Tim-Philipp Müller <tim at centricular dot net> * ext/amrnb/amrnbparse.c: (gst_amrnbparse_query): * ext/mad/gstid3tag.c: (gst_id3_tag_src_query): * ext/mad/gstmad.c: (gst_mad_src_query): * ext/mpeg2dec/gstmpeg2dec.c: (gst_mpeg2dec_src_query): * ext/sidplay/gstsiddec.cc: * gst/mpegstream/gstmpegparse.c: (gst_mpeg_parse_handle_src_query): * gst/realmedia/rmdemux.c: (gst_rmdemux_src_query): Pass unhandled queries upstream (useful e.g. for SEEKING query) (fixes #325652; based on patch by: Philippe); make rmdemux return FALSE for position queries, instead of setting -1 as value and returning TRUE. Btw, please add a surname to your real name in your bugzilla account so that we can attribute patches to you properly (also makes it easier to tell you apart from other Philippes) :)