After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 325574 - Can't build evo 2.5.4, sed problem
Can't build evo 2.5.4, sed problem
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: general
2.6.x
Other Linux
: High normal
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
: 324478 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-01-03 05:26 UTC by Evandro Giovanini
Modified: 2013-09-13 00:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fixes the build (702 bytes, patch)
2006-01-04 11:06 UTC, Sebastien Bacher
committed Details | Review

Description Evandro Giovanini 2006-01-03 05:26:36 UTC
Making all in shell
make[2]: Entering directory `/home/evandro/cvs/evolution-2.5.4/shell'
sed -e 's|\@BINDIR_IN_SERVER_FILE\@|/opt/gnome2//bin|'\
        -e 's|\@PRIVLIBEXECDIR_IN_SERVER_FILE\@|/opt/gnome2//libexec/evolution/2.6|'\
        -e 's|\@COMPONENTDIR_IN_SERVER_FILE\@|/opt/gnome2//lib/evolution/2.6/components|'\
        -e 's|\@VERSION\@|2.6|'                         \
        -e 's|\@EXEEXT\@||'                             \
        -e 's|\@SOEXT\@|.so|'                           \
        -e 's|\@INTERFACE_VERSION\@|2.6|' GNOME_Evolution_Shell.server.in.in > GNOME_Evolution_Shell.server.in
sed: -e expression #1, char 46: unknown option to `s'
make[2]: *** [GNOME_Evolution_Shell.server.in] Error 1
rm GNOME_Evolution_Shell.server.in
make[2]: Leaving directory `/home/evandro/cvs/evolution-2.5.4/shell'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/evandro/cvs/evolution-2.5.4'
make: *** [all] Error 2
evandro@debian:~/cvs/evolution-2.5.4$


System is Debian etch. GNOME built with jhbuild (CVS evo also doesn't build). 2.5.3 builds.
Comment 1 Evandro Giovanini 2006-01-03 05:28:20 UTC
Other dirs don't build as well.
Comment 2 Harish Krishnaswamy 2006-01-03 16:20:32 UTC
Hmm...Builds for me. 
You probably have done that already but can you please confirm if your sources are  up-to-date. Anybody else on Debian facing the issue ?
Comment 3 Evandro Giovanini 2006-01-04 02:50:23 UTC
Tried a clean CVS checkout to no avail. Then I started playing with older versions to find where the problem was introduced (like I said, 2.5.3 works but 2.5.4 doesn't).

I did some more testing. Apparently evo checkout with -D 20051217 is the latest one that works, -D 20051218 doesn't (also a clean checkout). I suspect the problem is related to the following commit:

2005-12-17  Tor Lillqvist  <tml@novell.com>

	* configure.in: Include libedataserver-$EDS_PACKAGE in the
	requirement list for E_WIDGETS.

	Set bindir_in_server_file, privlibexecdir_in_server_file and
	componentdir_in_server_file. On Unix, they are the same as bindir,
	privlibexecdir and componentdir respectively. On Win32, use paths
	relative from lib/bonobo/servers. AC_SUBST these variables.

	* server.mk: Substitute the values above new variables for the
	corresponding @..._IN_SERVER_FILE@ strings in the .server.in.in
	files.

	* addressbook/gui/component/GNOME_Evolution_Addressbook.server.in.in
	* calendar/gui/GNOME_Evolution_Calendar.server.in.in
	* calendar/gui/alarm-notify/GNOME_Evolution_Calendar_AlarmNotify.server.in.in
	* mail/GNOME_Evolution_Mail.server.in.in
	* shell/GNOME_Evolution_Shell.server.in.in
	* shell/GNOME_Evolution_Test.server.in.in: Correspondingly, use
	the @..._IN_SERVER_FILE@ strings.

	* evolution-plugin.pc.in
	* evolution-shell.pc.in: Use @privsolibdir@ to set privlibdir.
Comment 4 Sebastien Bacher 2006-01-04 10:56:17 UTC
It does the same on Ubuntu, changing "server.mk" to be a one liner instead of using "\" chars workaround the issue
Comment 5 Sebastien Bacher 2006-01-04 11:06:27 UTC
Created attachment 56766 [details] [review]
fixes the build

The issue seems to be that there is no space before the "\", that patches fixes the issue
Comment 6 André Klapper 2006-01-07 00:34:46 UTC
confirming; setting priority, target, blabla :-)
Comment 7 Tor Lillqvist 2006-01-07 11:39:53 UTC
Patch applied. Sorry for breaking server.mk. Any idea why this was required on Debian (and Ubuntu)? Do you use a significantly different shell version or something?
Comment 8 Sebastien Bacher 2006-01-07 13:11:24 UTC
That is due to the make version, it works with 3.80 but not with the 3.81 candidate packaged by Debian/Ubuntu. The "\" doesn't create an espace with the new version so everything is attached "sed -e '....'-e...."
Comment 9 André Klapper 2006-01-09 15:50:00 UTC
*** Bug 324478 has been marked as a duplicate of this bug. ***