Created attachment 56655 [details] [review]
Patch against 0.10.0

Just a note about the above patch : apply it inside gstreamer-0.10.0 directory with "patch -p1".

Last note : while at it I added the possibility to query position

The commited patch is against Makefile.in, it should be against Makefile.am .

Also, fdsrc is conditionnaly compiled if there's a socket.h (#if HAVE_SYS_SOCKET_H), shouldn't it be the case for fdsink too ?

Finally, if you could, you might want to implement the GstURIHandler interface, it's not complicated to implement (see the bottom of fdsrc.c, using the same protocol, but with GST_URI_SINK).

Created attachment 56664 [details] [review]
patch v2

The patch is against 0.10.1 now and against Makefile.am.
It adds GstURIHandler interface.
But it is still not conditionally compiled since we don't use socket. Should we ?

Created attachment 56781 [details] [review]
patch v3 against 0.10.1

This patch add a control socket since we need one to prevent blocking fds from causing trouble when changing state.

Committed in CVS, thanks for the patch!

        * plugins/elements/Makefile.am:
        * plugins/elements/gstelements.c:
        * plugins/elements/gstfdsink.c: (_do_init),
        (gst_fd_sink_base_init), (gst_fd_sink_class_init),
        (gst_fd_sink_init), (gst_fd_sink_dispose), (gst_fd_sink_query),
        (gst_fd_sink_render), (gst_fd_sink_check_fd), (gst_fd_sink_start),
        (gst_fd_sink_stop), (gst_fd_sink_unlock), (gst_fd_sink_update_fd),
        (gst_fd_sink_set_property), (gst_fd_sink_uri_get_type),
        (gst_fd_sink_uri_get_protocols), (gst_fd_sink_uri_get_uri),
        (gst_fd_sink_uri_set_uri), (gst_fd_sink_uri_handler_init):
        * plugins/elements/gstfdsink.h:
        Port fdsink to 0.10 (patch by Philippe Rouquier) (Fixes #325490)