GNOME Bugzilla – Bug 325166
Import folder should be configurable
Last modified: 2006-09-14 13:56:48 UTC
There should be a way to configure the directory in to which f-spot imports photos. Now f-spot just creates a directory called "Photos" in the home directory root, but I, for example, would like to have the items on my desktop/home directory to be in small case and in Finnish. I've looked through everything even in gconf but there just doesn't seem to be any way to change this.
There is no gconf key but it would be fairly simple to add. The value is defined in Global.cs can could be read from gconf.
*** Bug 329037 has been marked as a duplicate of this bug. ***
Please add this also. Here is my story: I am an amateur photographer and have a pretty heavy collection of photos. I have a very small system partition and a large (110gb) data partition that I mounted on my ~/Desktop (don't ask why, I'm weird!). The photos really need to be imported to ~/Desktop/photographie. Not in my home folder. Furthermore, please, please allow, when importing, to put those pictures in a subfolder that can be named manually. For example, I have a tendency to keep my filesystem clean by having a structure like this: "~/Desktop/photographie/2006 - cute people/" I would like to avoid manually cut-pasting photos from my camera to my folders, and having to import them with f-spot later on.
I am adding this post from the mailing list to ensure that it doesn't get lost. http://mail.gnome.org/archives/f-spot-list/2006-February/msg00023.html It contains a patch for the issue.
bug 337250 is also a duplicate of this one, but it contains a patch: http://bugzilla.gnome.org/attachment.cgi?id=66913&action=view
Forgive me if this is the wrong place to ask this, but the patch in Comment #4 looks like it will do what I would like, could someone please explain how to use that? I assume I will have to recompile F-Spot to use it, but I am new to this, so any advice or suggestions would be appreciated.
Perhaps check http://f-spot.org/How_To_Build
(In reply to comment #7) > Perhaps check http://f-spot.org/How_To_Build > Thanks, I actually wasn't expecting it to be that easy to find the information.
*** Bug 337250 has been marked as a duplicate of this bug. ***
review for the patch submitted in comment #4... about the patch itself: - please make your diff from the f-spot directory - please add a little context in you diff - please use the unified (-u) variant of diff - one patch, one fix. If you want to clean up the glade file, do not do it in another patch. about the content: - in the pref dialg, the entry should be a file entry - the Preference should have a default value but the idea is great, I will make it compliant to the f-spot standard, since we fixed this as part of the goal 3.
Jeff (comment #3), I opened the bug #351624 for your request.
Created attachment 71072 [details] [review] Clean patch for this issue please comment
Created attachment 71233 [details] [review] Updated version This new patch fix a small bug in the UI and creates the Photos directory at first time using the Catalog.GetString("Photos")
Patch looks good and works fine here. I have a few UI concerns though. In the preferences dialog: 1) Should we change "Photos directory" to "Import directory"? It seems more accurate, but also might be unnecesarily confusing. 2) Grammatical error in the description. I'd say "This sets the destination for imported images" or even better "This sets the destination for images imported into F-Spot" Also, do we want to say "copied" here? Since I can import without copying and importing without copying will ignore this setting it seems a bit misleading. In the import dialog: 3) Do we want to change the "Copy file to the Photos folder" to either say "Copy file(s) to the import folder" or maybe even put STORAGE_PATH to avoid any confusion. We'd have to figure out what to do with long STORAGE_PATH's though. I'm not entirely sure that any of this should be changed besides the grammatical error, and maybe when the rewrite of import happens this will all become clearer, but now that we are changing the semantics of Photos a bit, I think a bit of UI review is in order.
Created attachment 71296 [details] [review] updated version UI fixes: - Renamed 'Photos directory' to 'Import directory' - grammatical error: fixed - Changed 'copy file to Photos folder' to 'copy file(s) to import folder' in the import dialog This patch is also part of the patch I made for bug #344361
This bug should be closed as soon as bug #344361 has been committed. Bug #344361 is in Ready for Commit state
bug #344361 is closed and a patch is in CVS, solving also this one.