After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 325058 - invalid_arg_error_dialog not following HIG
invalid_arg_error_dialog not following HIG
Status: RESOLVED FIXED
Product: gconf-editor
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Gconf Editor Maintainers
Gconf Editor Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-12-27 13:54 UTC by Kristof Vansant
Modified: 2006-01-30 06:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Kristof Vansant 2005-12-27 13:54:14 UTC 
static void
 invalid_arg_error_dialog (GtkWindow  *parent,
@@ -36,48 +36,51 @@
        dialog = gtk_message_dialog_new (parent,
                                         GTK_DIALOG_DESTROY_WITH_PARENT,
                                         GTK_MESSAGE_ERROR,
-                                        GTK_BUTTONS_CLOSE,
+                                        GTK_BUTTONS_OK,
                                         _("Invalid key \"%s\": %s"),
                                         key, error_message);
-       g_signal_connect (dialog, "response",
-                         G_CALLBACK (gtk_widget_destroy), NULL);
-
-       gtk_window_set_resizable (GTK_WINDOW (dialog), FALSE);
-
-       gtk_widget_show (dialog);
+
+       gtk_dialog_run(GTK_DIALOG(dialog));
+       gtk_widget_destroy(dialog);
 }
Comment 1 Fernando Herrera 2006-01-30 06:06:13 UTC 
Thank you very much for the patch.
Applied in CVS:
2006-01-30  Fernando Herrera  <fherrera@onirica.com>

        * src/main.c: (invalid_arg_error_dialog): HIGfy error dialog.
        Patch from Kristof Vansant. Fixes bug #325058.