After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 325039 - Add "Aunt Mary" (a frustratingly difficult Klondike variation)
Add "Aunt Mary" (a frustratingly difficult Klondike variation)
Status: RESOLVED FIXED
Product: aisleriot
Classification: Other
Component: games
git master
Other All
: Normal enhancement
: gnome-3-2
Assigned To: aisleriot-maint
aisleriot-maint
: 611403 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-12-27 03:22 UTC by Alan Horkan
Modified: 2011-08-15 22:25 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
code for Aunt Mary a difficult klondike variation (2.58 KB, text/plain)
2005-12-27 03:26 UTC, Alan Horkan
Details
documentation for Aunt Mary (docbook xml) (2.81 KB, text/plain)
2005-12-27 03:29 UTC, Alan Horkan
Details

Description Alan Horkan 2005-12-27 03:22:02 UTC
Yet another klondike variation but this one is winnable less than 1% of the time if even (even if you dont shuffle it is still difficult to win)

Scheme and docs to follow.
Comment 1 Alan Horkan 2005-12-27 03:26:28 UTC
Created attachment 56419 [details]
code for Aunt Mary a difficult klondike variation
Comment 2 Alan Horkan 2005-12-27 03:29:05 UTC
Created attachment 56420 [details]
documentation for Aunt Mary (docbook xml)
Comment 3 Callum McKenzie 2006-01-16 08:15:30 UTC
Looks good. I've put it in CVS ready for the next release (in about half an hours time).

I did strip out most of the extraeneous comments: I don't think we need to record what changed from the Klondike and we only need one way to play the cards, so there is no point cluttering the file up with unused alternatives.

I also updated the set-lambda function to use droppable?. This is just a difference in the versions of Klondike we're working with. Ideally we wouldn't need set-lambda at all, but for now we're stuck with its brittleness.

Good work.
Comment 4 Alan Horkan 2006-01-16 09:22:26 UTC
Thanks.   I do like having comments a lot more than most developers but the bits you stripped out were entirely reasonable.  I'll have to make sure to follow up on the "King Only" question, and think some more about the other way of dealing out the cards, maybe put it up on my own site or something.  
Comment 5 Christian Persch 2009-07-07 13:50:57 UTC
I was conducting a licence audit, and noticed that aunt_mary.scm doesn't have a licence header. It includes klondike.scm which is GPL2+, so it's clearly derived and thus must be GPL itself; the question is whether it's GPL2+ or 2 only. Alan, can you please clarify?
Comment 6 Christian Persch 2009-07-20 11:13:05 UTC
I've removed aunt_mary.scm from the list of installed games in aisleriot/rules/Makefile.am for now, until this question is cleared up. (The file itself is there, just not installed or disted.)
Comment 7 Christian Persch 2009-08-13 13:49:21 UTC
Feature freeze gone; Aunt Mary won't be part of aisleriot 2.28.
Comment 8 Christian Persch 2010-01-28 11:20:22 UTC
Feature freeze gone; Aunt Mary won't be part of aisleriot 2.30.
Comment 9 Christian Persch 2010-02-28 14:56:24 UTC
*** Bug 611403 has been marked as a duplicate of this bug. ***
Comment 10 Josselin Mouette 2010-02-28 15:11:19 UTC
Sorry for the dupe, the bug title wasn’t very descriptive.

Could you at least remove Aunt Mary from the documentation if it’s not going to be distributed?
Comment 11 Christian Persch 2010-02-28 15:14:15 UTC
It already has been removed from the docs on 2.29.x.
Comment 12 Christian Persch 2010-06-04 18:48:14 UTC
Maybe we should just independently re-implement the Aunt Mary SCM code from the rules without looking at the current code. Shouldn't be too much work, since it's just a derivation from klondike.scm.
Comment 13 Tim Nelson 2010-12-06 01:14:24 UTC
I note that no e-mail address for Alan Horkan is in the CC list; this applies to at least one of his other bugs.  I googled him, and sent e-mail to try to get him to put one in.
Comment 14 Alan Horkan 2010-12-06 02:23:44 UTC
My old email address should still be valid but I hardly ever use it anymore it's so full of junk, I got a message suggesting I check this report. 

I'm surprised anyone ever felt it necessary to ask about the GPL. I never said anything about "GPL 2 only". 
The default wordling of the GPL is GPL or "any later version" so I'd have to deliberately say something to suggest otherwise if I didn't want to accept that. By my submissions to the project it would seem pretty clear I'm accepting the license the maintainer wants, and most of my contributions have been derivatives of the existing code making it difficult for me to even claim copyright in the first place. 

I hope that settles the matter. 

(On an unrelated note I played Aisleriot recently and was absolutely horrified to see someone had removed "Klondike". I was able to make sense of it but there is NO WAY for an ordinary user to know that it at it is still there by another name. Think it was in Gnome 2.28 so this may have been fixed in the meantime.)
Comment 15 Tim Nelson 2010-12-06 02:52:46 UTC
I'm on 2.30.1 and it's there.
Comment 16 Christian Persch 2010-12-08 22:54:29 UTC
(In reply to comment #14)
> I'm surprised anyone ever felt it necessary to ask about the GPL. I never said
> anything about "GPL 2 only". 
> The default wordling of the GPL is GPL or "any later version" so I'd have to
> deliberately say something to suggest otherwise if I didn't want to accept
> that. By my submissions to the project it would seem pretty clear I'm accepting
> the license the maintainer wants, and most of my contributions have been
> derivatives of the existing code making it difficult for me to even claim
> copyright in the first place.
The file was missing ANY licence header, so there was no way to infer the licence. Thanks for clearing it up.

The other people working on this file were Calum and Andreas; CC:ing them so they too can give their permission.
Comment 17 Alan Horkan 2010-12-09 18:32:37 UTC
The whole Aisleriot project seem to lack a CREDITS list (one person is not a list) or even THANKS file so I'd be very surprised if anyone expected anything more than whatever version of the GPL Jonathan Blandford set for the project. Anyhow, best of luck getting the level of certainty you feel is necessary.
Comment 18 Christian Persch 2010-12-09 18:38:44 UTC
I was looking at the git history of the specific file, of course. (And the licence is whatever the file itself says it is, if it has a copyright header. That's why I need this clarification here.)
Comment 19 Christian Persch 2011-01-12 13:54:50 UTC
Calum and Andreas: can you please comment here to say if you're ok / not-ok with this? Thanks!
Comment 20 Andreas Røsdal 2011-05-02 14:52:45 UTC
I'm OK with GPL 3-or-later for this. However, I didn't write the patch which was applied to aunt_mary.scm in bug #358014. As a maintainer I only committed a patch, which was from Vincent Povirk if I remember correctly.

 - Andreas
Comment 21 Callum McKenzie 2011-05-02 19:16:12 UTC
I'm fine with GPL 3-or-later too.
Comment 22 Christian Persch 2011-08-09 20:26:33 UTC
Vincent: I guess you're ok with this too? :-)
Comment 23 Vincent Povirk 2011-08-15 22:12:53 UTC
Yep, GPL 3+ is fine.
Comment 24 Christian Persch 2011-08-15 22:25:02 UTC
Thanks everyone! Added Aunt Mary back, will be in 3.1.1 release.