After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 324761 - gimptool should check GTK/Glib flags at runtime
gimptool should check GTK/Glib flags at runtime
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: General
2.2.x
Other All
: Normal normal
: 2.2
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2005-12-22 01:20 UTC by Ari Pollak
Modified: 2008-01-15 13:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
somewhat improved patch (1014 bytes, patch)
2006-01-05 09:27 UTC, Sven Neumann 		committed Details | Review

Description Ari Pollak 2005-12-22 01:20:46 UTC 
Currently, gimptool, by default and without PKG_CONFIG set, returns values for --cflags and --libs that were determined at gimp compile-time. However, I'm not sure there shouldn't be any reason for this, and gimptool should check GTK and Glib's flags at runtime instead.
Comment 1 Sven Neumann 2005-12-22 10:34:16 UTC 
I don't see a reason why we should not make such a change.
Comment 2 Sven Neumann 2005-12-28 17:58:06 UTC 
Could we have the patch that you are using for the debian package attached to this bug report, please?
Comment 3 Ari Pollak 2005-12-28 18:16:53 UTC 
All I'm doing is this at the top of gimptool-2.0.in:

if [ -z "${PKG_CONFIG}" ]; then
    PKG_CONFIG=/usr/bin/pkg-config
fi

I'd think this shouldn't be the final fix, but instead at least have it be more integrated with the rest of the checks & test for the actual existence of pkg-config.
Comment 4 Sven Neumann 2006-01-05 09:27:40 UTC 
Created attachment 56804 [details] [review]
somewhat improved patch
Comment 5 Sven Neumann 2006-01-06 16:05:32 UTC 
I have now applied this change to both branches. Closing as FIXED.

2006-01-06  Sven Neumann  <sven@gimp.org>

        * gimptool-2.0.in: if available use pkg-config to determine
        compiler and linker flags at runtime. Fixes bug #324761.