GNOME Bugzilla – Bug 324757
eog accels keybinding file (to allow custom keybindings)
Last modified: 2006-10-20 10:18:44 UTC
"Cant please all of the people all of the time" but maybe if Eog dumped the keybindings in an accels file like other applications do it would allow users (who dont mind manually editing a config file) to customise the keybindings. Being able to customise keybindings without needing to recompile makes it easier for people to test out alternative keybindigns and gives great flexibility to anyone not happy with the defaults. Hope you will consider this suggestion
That's as easy as calling gnome_accelerators_sync() on shutdown.
*** Bug 334028 has been marked as a duplicate of this bug. ***
Done in HEAD and eog-ng. Thanks! 2006-09-06 Lucas Rocha <lucasr@gnome.org> * shell/main.c: save customized keybindings on application shutdown (Fixes bug #324757).
remarkable how simple the required change was http://cvs.gnome.org/viewcvs/eog/shell/main.c?r1=1.60.2.5&r2=1.60.2.6 at least now we have a workaround for anyone unhappy with the default keybindings, save for a few corner cases where additional actions might need to be exposed to allow customisation (for example I would want page up and page down to scroll up and down the page but others would want them to go to next image but those are not normally included in the accels dump from an application) Thanks
It is a bad idea to only save whatever configuration change on application exit. To prevent losing preferences in case of crash any configuration change should be saved when that configuration changes (and not only on application shutdown)
(In reply to comment #5) > It is a bad idea to only save whatever configuration change on application > exit. that issue only becomes relevant later on if and when it becomes possible to configure the keybindings interactively. I'm just asking for the very basics or writing out the file and reading it in, so users would need to stop EoG edit the file and then restart to test out new keybindings. Sure there could be a more detailed implementation but just getting the basics done sooner rather than later gives a whole lot more flexibility.