After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 324692 - Incorrect duplicate-accel message
Incorrect duplicate-accel message
Status: VERIFIED FIXED
Product: Gnumeric
Classification: Applications
Component: GUI
git master
Other All
: Normal minor
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2005-12-21 11:32 UTC by Vincent van Adrighem
Modified: 2006-02-16 00:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot of bug (167.96 KB, image/png)
2005-12-22 10:46 UTC, Vincent van Adrighem
Details

Description Vincent van Adrighem 2005-12-21 11:32:25 UTC
On startup (in terminal) I get this error message:
** (gnumeric:7845): WARNING **: In het menu `Be_werken' wordt de toets `n' zowel gebruikt voor `Op_nieuw' als voor `K_nippen'.
Which means:
In the `Edit' menu, the key `n' is used for both `Op_nieuw' and `K_nippen'.

This would be very nice, but it's not true. `Opnieuw' (Redo) is translated as `Opni_euw'. So the error message is incorrect.
You can check with:
msgunfmt /usr/share/locale/nl/LC_MESSAGES/gnumeric.mo | grep -A 1 "Redo"
msgunfmt /usr/share/locale/nl/LC_MESSAGES/gnumeric.mo | grep -A 1 "Cu_t"

You will see that they don't conflict.
Comment 1 Morten Welinder 2005-12-21 15:25:15 UTC
Look at what is actually in the menu.  That's what matters.

Please supply a screenshot with the edit menu open.
Comment 2 Andreas J. Guelzow 2005-12-22 02:58:40 UTC
Vincent, if I run the commands you suggest I get a double use of the 'n' key:

[aguelzow@kirkman ~]$ msgunfmt /usr/share/locale/nl/LC_MESSAGES/gnumeric.mo | grep -A 1 "Redo"
msgid "Redo"
msgstr "Opnieuw"
--
msgid "Redo the undone action"
msgstr "De ongedaan gemaakte actie opnieuw uitvoeren"
--
msgid "_Redo"
msgstr "Op_nieuw"
[aguelzow@kirkman ~]$ msgunfmt /usr/share/locale/nl/LC_MESSAGES/gnumeric.mo | grep -A 1 "Cu_t"
msgid "Cu_t"
msgstr "K_nippen"
[aguelzow@kirkman ~]$

Comment 3 Vincent van Adrighem 2005-12-22 10:46:55 UTC
Created attachment 56290 [details]
screenshot of bug

The screenshot shows the open edit menu (bewerken). You can see the error in the terminal.

It's strange that you do have the double n bindings. We need to fix that. But in cvs HEAD (and in my 1.6.1) it's fixed.
Comment 4 Vincent van Adrighem 2005-12-22 11:00:34 UTC
And I said fixed because it used to be a problem. Please take a look at bug #310874 for some more info on that.
Comment 5 Vincent van Adrighem 2005-12-22 14:45:52 UTC
Forgot to change back
Comment 6 Morten Welinder 2005-12-22 15:08:56 UTC
When we build the interface and do the key check, we are using the redo
translation from gtk+:

> msgunfmt /opt/gnome/share/locale/nl/LC_MESSAGES/gnumeric.mo | grep -A1 Cu_t
msgid "Cu_t"
msgstr "K_nippen"

Later we are using the dynamically-created text and translation from Gnumeric.
The complaint is thus wrong, but I am not 100% sure how to fix it.  Ignore
it for now.
Comment 7 Vincent van Adrighem 2006-02-14 19:41:15 UTC
When is the check performed? On creation of the menus? Can we not do the check later then....or create the dynamic menu entries immediately?
Comment 8 Morten Welinder 2006-02-15 17:56:08 UTC
I believe that adding

	wb_control_undo_redo_labels (WORKBOOK_CONTROL (wbcg), "", "");

in function wbc_gtk_init just before

	gtk_container_foreach (GTK_CONTAINER (gtk->menu_zone),
			       (GtkCallback)check_underlines,
			       (gpointer)"");

might fix the problem, but I am not able to test it myself.
Comment 9 Morten Welinder 2006-02-15 18:25:42 UTC
Never mind, I found a test machine and the fix works for me.
Comment 10 Vincent van Adrighem 2006-02-16 00:43:21 UTC
Verified by patching my gnumeric...the error message does indeed disappear. Great job Morten. Thank you very much.