After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 324662 - Bookmarks should be first in address bar
Bookmarks should be first in address bar
Status: RESOLVED DUPLICATE of bug 317248
Product: epiphany
Classification: Core
Component: [obsolete] URL bar
1.9.x
Other All
: Normal enhancement
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-12-21 01:16 UTC by Adam Petaccia
Modified: 2008-02-18 23:15 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement



Description Adam Petaccia 2005-12-21 01:16:14 UTC
I'm sorry, I didn't know if this was "bookmarsk", "history", or "toolbars"
because it affects all three.  When I type something into the address bar, if
its a bookmark that I have, then it shows up, but it should show up above my
history.  Otherwise, having to scroll and choose through my various combined
history/bookmarks is tedious, and defeats the purpose of the awesome bookmark
typing system.
Comment 1 lexual 2006-02-15 08:07:19 UTC
confirming
Comment 2 Diego Escalante Urrelo (not reading bugmail) 2007-01-07 00:39:37 UTC
Actually we do the following:

static void
init_relevance_col (GValue *value, EphyNode *node, int group)
{
        int relevance = 0;

        /* We have three ordered groups: history's base
           addresses, bookmarks, deep history addresses */

        if (group == BOOKMARKS_GROUP)
        {
                relevance = 1 << 5;
        }
        else if (group == HISTORY_GROUP)
        {
                const char *address;
                int visits;

                visits = ephy_node_get_property_int
                        (node, EPHY_NODE_PAGE_PROP_VISITS);
                address = ephy_node_get_property_string
                        (node, EPHY_NODE_PAGE_PROP_LOCATION);

                visits = MIN (visits, (1 << 5) - 1);

                if (is_base_address (address))
                {
                        relevance = visits << 10;
                }
                else
                {
                        relevance = visits;
                }

        }


        g_value_set_int (value, relevance);
}

That basically means that we give relevance like this:
1. Really visited websites (no matter if they are history items or bookmark items)
2. Bookmarks
3. Rest

It's a matter of taste
Comment 3 Adam Petaccia 2007-02-01 15:39:37 UTC
I personally think that it could look better, especially because have the time they're the same website and I get to see something like this:

----------------------------------------------------------
http://www.foo.com/blah/some/reallylong/pathname.html
http://www.foo.com/blahblahblah/dumb.html
FOO Website - Awesomeness!
http://wtf.foo.com/ilikedirt/anotherwebpage.html.
----------------------------------------------------------

Also, its annoying because it will list the recent bookmark _in_addition_ to the title you give it, so once again, please bear with the ASCII graphic:

+--------------------------------------------------------+
[Packages                                                ] <-- what I've typed in
  http://packages.ubuntu.com
  Ubuntu Packages
+--------------------------------------------------------+

And here those to options turn out to be exactly the same.  

Also, in turns of preference, I bookmarked them for a reason, because usually I want to go to that webpage more than the others (which I didn't bookmark).  Me bookmarking it should give it priority.  And having URLs with friendly names mixed together looks... odd at best.
Comment 4 Diego Escalante Urrelo (not reading bugmail) 2007-05-31 19:51:46 UTC
See bug #392979
Comment 5 Reinout van Schouwen 2008-02-18 23:10:49 UTC
Looks like this is the same issue as 317248. Feel free to reopen if you disagree.

*** This bug has been marked as a duplicate of 317248 ***