After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 324641 - Rhythmbox crashes on random play
Rhythmbox crashes on random play
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: playback
HEAD
Other All
: Normal critical
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 327916 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-12-20 21:54 UTC by Alexander Hunziker
Modified: 2006-01-21 12:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch for random play order (2.34 KB, patch)
2005-12-20 23:48 UTC, Jonathan Matthew 		none Details | Review
better patch (7.10 KB, patch)
2005-12-29 23:56 UTC, Jonathan Matthew 		committed Details | Review

Description Alexander Hunziker 2005-12-20 21:54:29 UTC 
Steps to reproduce:
1. Play full random for a while
2. 
3. 


Stack trace:


Other information:
Rhythmbox crashes with the following error message:

Rhythmbox-ERROR **: file rb-play-order-random.c: line 363
(rb_random_play_order_go_next): assertion failed: (entry == NULL || entry ==
rb_history_current (history))

I'm using a custom-compiled Rhythmbox from CVS, built against GStreamer 0.10.
Comment 1 Jonathan Matthew 2005-12-20 23:00:54 UTC 
Does this only happen when you've changed the browser/search so that the current playing song is not shown, and either the song ends or you hit next/prev?
Comment 2 Alexander Hunziker 2005-12-20 23:17:17 UTC 
I can reproduce it in the situation you are mentioning. I will observe rhythmbox in the next days to see whether it does it in other situations, too.
Comment 3 Jonathan Matthew 2005-12-20 23:48:57 UTC 
Created attachment 56231 [details] [review]
patch for random play order

This should fix the random play order.  The shuffle play order suffers from the same problem, but I don't have time to fix that right now.
Comment 4 Alexander Hunziker 2005-12-21 10:01:59 UTC 
What is the difference between random and shuffle play?

Anyway, the crash definitely only happens in the situation described by you above.
Comment 5 Jonathan Matthew 2005-12-21 10:53:44 UTC 
The random play order you get by selecting both shuffle and repeat weights songs on rating and time since last play, and the shuffle play order won't (in theory) play a song again until all other songs have been played.

I've tested the above patch for about 6 hours of actual playback with no problems.
Comment 6 Jonathan Matthew 2005-12-29 23:56:04 UTC 
Created attachment 56522 [details] [review]
better patch

fixes shuffle play order too.
Comment 7 James "Doc" Livingston 2006-01-05 10:14:42 UTC 
This looks fine to be committed to cvs.
Comment 8 Jonathan Matthew 2006-01-05 13:02:58 UTC 
Committed, thanks.
Comment 9 Christian Kirbach 2006-01-21 12:30:12 UTC 
*** Bug 327916 has been marked as a duplicate of this bug. ***