After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 324391 - face tagging inside photos (like used on facebook.com)
face tagging inside photos (like used on facebook.com)
Status: RESOLVED WONTFIX
Product: f-spot
Classification: Other
Component: Tags
WISHLIST
Other All
: Normal enhancement
: ---
Assigned To: F-spot maintainers
F-spot maintainers
gnome[unmaintained]
: 471210 578808 Mike (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-12-18 16:09 UTC by Henry Gomersall
Modified: 2018-07-12 00:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
tag-coords.patch (12.48 KB, patch)
2008-01-02 08:15 UTC, Maxxer
none Details | Review
screenshot (21.72 KB, image/jpeg)
2008-01-02 08:19 UTC, Maxxer
  Details
Full implementation for tagging regions (70.86 KB, patch)
2008-05-07 18:12 UTC, Robert Paskowitz
needs-work Details | Review

Description Henry Gomersall 2005-12-18 16:09:26 UTC
A very powerful feature would be to be able to assign tags to individual people
within a photo. This could be linked to the eds backend, so suddenly all photos
of an individual are related to their contact information.

A reasonable implementation of this is used in the photo galleries on
facebook.com (a university networking website). It works as follows:
In the photo edit mode, clicking on a photo brings up the add person box which
is a list of your "friends" (these are all those registered users that are
confirmed to be mutual friends). Now, whenever the photo is viewed, all the
people present in the photo are listed at the bottom. Mouse over the name and a
box is put around their face.

In the case of f-spot, the add friends list could come from an eds backend. This
would give an exceptionally useful ability to link contacts to their photos in a
better way than with comments.
Comment 1 Larry Ewing 2006-02-26 04:38:26 UTC
yeah this is an interesting idea.
Comment 2 Fabian Zimmermann 2006-11-30 19:17:58 UTC
This functionality would be great. Please implement it quickly.
Comment 3 Michael Wayne Goodman 2007-04-17 06:25:15 UTC
I think this feature should now have a stronger push, given that Andrzej is working on face detection algorithms for the Summer of Code.  Surely it would help him out quite a bit (if he doesn't just implement it himself).

Sorry I don't have much time to put code where my mouth is :P
Comment 4 Gabriel Burt 2007-09-21 23:01:25 UTC
*** Bug 471210 has been marked as a duplicate of this bug. ***
Comment 5 Maxxer 2008-01-02 08:15:08 UTC
Created attachment 101978 [details] [review]
tag-coords.patch

A first shot... It's really a raw stub of what a possible solution would look like. 

This patch basically allows the user to attach a tag to a specific area of a picture.
This requires modification to photo_tags table on the db, which needs to include the coordinates of the tag over the image. 
A button in the tools/edit area (below image) is provided to assign an "area tag".
Actually nothing is displayed back on the image (sorry), but the coords are just printed out to console at load time. 

I don't know if this is the best solution. Adding a comment and not only a tag to an area would be even better, IMHO.


If this is a good way I'll be happy to finish it over.
Comment 6 Maxxer 2008-01-02 08:19:49 UTC
Created attachment 101979 [details]
screenshot
Comment 7 Marcus 2008-01-05 01:53:48 UTC
This would be a great feature!  I always wanted to have something like this to document old family pictures.  Flickr has something like this on their website, where users can highlight an area of the pictures and associate a comment with it.

It reminds me of this

http://rdfweb.org/2002/01/photo/

an experimental implementation of this feature with FOAF annotations for identification of the people in the photograph.  The regions of the pictures are stored as SVG also, and Amaya, W3C browser, implemented it

http://www.w3.org/2001/08/rdfweb/svg-foaf.html
Comment 8 Robert Paskowitz 2008-05-07 18:12:26 UTC
Created attachment 110531 [details] [review]
Full implementation for tagging regions

Patch is against svn3849. Three icon files (from Tango project) available at http://confucius.ca/fspot/ should be places in the icons/ directory.

To use the functionality in the patch, you may make a selection while
in the single photo view mode and click on the monkey icon on the
toolbar. After selecting the tag to associate, the region will be
surrounded in a green box. Right-clicking on that region will show at
the top of the menu the name of the tag, and at the bottom two new
menu items; one to remove the tagged region and another to associate
the region with a new tag.

There is also a menu item under the View menu to control if tagged
regions are shown or not (you may not always want them to be seen).

Database schema has been changed, but upgrading is not currently handled, so you should start with no DB.
Comment 9 Michael Van Dorpe 2009-01-07 11:08:02 UTC
It seems that Apple's iPhoto 2009 now has this feature, together with automatic recognition of faces. I have not tried it, so I am not sure whether f-spot can learn from that.

In any event, re comment 8 from Robert, I do not think that this feature should be included in f-spot unless there is a possibility to start from an existing database. Providing a solid upgrade path is more important than providing this new feature.
Comment 10 Robert Paskowitz 2009-01-07 12:58:53 UTC
The patch posted in comment 8 was a starting attempt to have a full implementation of facial identification and recognition added to F-Spot. In fact, I have another patch that was against F-Spot 0.4.1 that from my understanding of the features available in iPhoto 2009 full replicates the functionality (automatically detecting a face in a photo, determining the identity of the person, confirming if the recognition was correct, correcting when not, having the database for face recognition improve as corrections are made, allow searching on individuals, groups, groups with exclusions, ...) although it'd be unfair to say it matches the iPhoto features since it was completed 8 months before iPhoto 2009 was announced.

The patch doesn't deal with database upgrades for the simple fact that it wasn't worth the effort at the time, particularly knowing that the patch probably wouldn't be included, and if it were, there likely would have been other database changes in the interim, requiring the patch to be updated anyways.

As this patch was never added and there did not seem to be much interest, I stopped my effort to rewrite all the code I had to be suitable for inclusion in svn with the above patch.

If anyone wants to revive the effort, I will gladly provide them with all the work previously done to have the feature working against F-Spot 0.4.1
Comment 11 Kehan Harman 2009-02-02 19:06:34 UTC
I'd really love to have the feature in f-spot and I think it would definitely be worth pursuing it, although I have absolutely no knowledge of c / Mono development (I'm reasonably familiar with PHP & PERL).

I have been doing a little hacking of the f-spot photos.db to try to transfer my tags from G-thumb into it.

Just a question - how different is this approach from Andrzej Wytyczak-Partyka's approach at http://apart-dev.blogspot.com/2007/06/f-spot-face-detection.html (He's got a f-spot plugin that uses the openCV library)?
Comment 12 Maxxer 2009-04-13 21:07:17 UTC
*** Bug 578808 has been marked as a duplicate of this bug. ***
Comment 13 Rick Hallock 2009-07-14 17:49:49 UTC
Just a plug to encourage development on this.
I would really like use it, I have about 25000 family photos going back to 1995.

With IPhoto and all the web face recognition utilities coming out there will be more interest, I think the only reason there wasn't more before is people don't know how useful it could be.

I think IPhoto is the only one that does it, and I don't use MAC.
Picasa on the web works, but I can't get the tags back to my local pics.
Riya and the new face.com photofinder addin on facebook and all the other web systems have the same problem.


Comment 14 Olivier Guéry 2009-09-23 11:13:16 UTC
What append to the SOC project about face detection ?
http://apart-dev.blogspot.com/2007/06/f-spot-face-detection.html

These function have just landed in picasa 3.5
Comment 15 Maxxer 2009-12-15 14:26:03 UTC
*** Bug 604418 has been marked as a duplicate of this bug. ***
Comment 16 Javier Jardón (IRC: jjardon) 2010-01-14 14:37:52 UTC
Added link to digikam bug to support face recognition: https://bugs.kde.org/show_bug.cgi?id=146288
Comment 17 seb 2010-02-23 21:05:58 UTC
automatic face tagging would be a great thing in general!
Comment 18 Philip Ganchev 2010-05-21 00:58:42 UTC
Why was the patch by Robert Paskowitz not included? I think this would be very appreciated by users.
Comment 19 Robert Paskowitz 2010-05-21 02:07:53 UTC
If anyone is interested in renewing this effort, let me know, and I can provide the full work. 

The patch in comment 8 above was an attempt at a clean implementation of a portion of the overall work, in the hope that it would be more likely to be included in the tree. Unfortunately when there was no action on the initial work, I stopped cleaning up the initial work for inclusion.
Comment 20 Benedict Stein 2010-05-21 21:07:04 UTC
added https://bugs.launchpad.net/ubuntu/+source/f-spot/+bug/459868 - I'd really liek to see this feautre - but don't have the knowledge to code it - Thanks a lot Robert, if you're coding it.
Comment 21 Ruben Vermeersch 2010-05-22 19:59:38 UTC
Benedict: Please don't change the AssignedTo field unless you are the assignee.

Robert: Am certainly interested in this. This is a very high profile feature which I want badly. I will review the patch soon. Obviously, this is a quite invasive patch with a high impact on our architecture, so we must take care that it's implemented properly (we're also planning large changes in this area). I'm also not sure the UI in the screenshot is the best way to approach this problem, but that's something I'm going to talk about with UI designers next week at LGM in Brussels.

The best way to take this forward is probably by updating the patch (doesn't apply anymore) and then put it into a git branch. This will make it much easier to keep up-to-date and it provides a starting point to work towards where we want to go.

Sorry for the long time without review. I have recently taken over the maintenance of the project and one of my goals is to make sure this doesn't happen anymore.
Comment 22 Maxxer 2010-05-31 14:49:24 UTC
(In reply to comment #19)
> If anyone is interested in renewing this effort, let me know, and I can provide
> the full work. 

Robert, please send me the stuff, I'll be glad to try to implement or coordinate the work to merge it into F-Spot as soon as possible!

Looking forward to hear from you soon!

thanks
Comment 23 Ruben Vermeersch 2010-06-24 14:25:21 UTC
I have the feeling that the patches won't work anymore. But we should do it in a slightly different way than simply as an editor.

This would be a killer feature to have though, so if anyone wants to work on it, come and talk to me (it requires a bit of changes to the architecture to do it right, which need to be discussed).
Comment 24 Philip Gillißen 2010-07-16 08:28:15 UTC
(In reply to comment #23)
> This would be a killer feature to have though, so if anyone wants to work on
> it, come and talk to me (it requires a bit of changes to the architecture to do
> it right, which need to be discussed).

Hi Ruben!

I saw your comment on pittle[1] regarding getting things done in face recognition. Could you explain further if there's a testable version of Ali's work? I don't find any information about it and would offer my help to test etc.

It would be great if F-Spot could do such a thing!

Greetings, Philip

[1]: http://www.pittle.org/weblog/face-detection-on-f-spot-status-updates_519.html
Comment 25 André Klapper 2018-07-12 00:11:43 UTC
F-Spot has moved to https://github.com/f-spot/f-spot/issues

If this Bugzilla ticket is still valid in a recent version of F-Spot, please feel free to post this topic as a ticket in the F-Spot project on GitHub.

Closing this report as WONTFIX as part of Bugzilla Housekeeping as we are planning to shut down GNOME Bugzilla in favor of GNOME Gitlab.