GNOME Bugzilla – Bug 324346
the sidebar sucks
Last modified: 2006-07-14 19:46:46 UTC
Attached patch should fix that. Use cases: * make sure sidebar is hidden on startup. Start totem, click sidebar button to show. Expected: window becomes larger for new sidebar, video window does not change size. Reality: video window becomes smaller, sidebar takes rest of space. Totem window does not change size. Attached patch fixes that.
Created attachment 56101 [details] [review] fix
That's quite disgusting: + static gboolean was_ever_visible = FALSE; Fixed in CVS HEAD and gnome-2-12, thanks Ronald. 2005-12-18 Bastien Nocera <hadess@hadess.net> * src/totem-private.h: * src/totem-sidebar.c: (cb_resize), (cb_got_size), (on_sidebar_button_toggled): patch from Ronald Bultje <rbultje@ronald.bitfreak.net> to fix resizing of the sidebar (Closes: #324346)
*** Bug 313212 has been marked as a duplicate of this bug. ***
Yeah, it is; I just couldn't find anything better to fix it. I was hoping the size allocation would be 0, but that's not the case (it's 1, which may or may not be true for other computers). So this was the easiest way to make it work... Thanks for applying.
*** Bug 324435 has been marked as a duplicate of this bug. ***
*** Bug 334214 has been marked as a duplicate of this bug. ***
Ehm... using totem 1.4.0 the sidebar still eats up half of the window size when activating... And clicking it repeatedly causes seemingly randow window sizes... Seems like the sidebar still sucks a bit...
Reopening, as this still is the case in GNOME 2.14...
*** Bug 326229 has been marked as a duplicate of this bug. ***
*** Bug 313021 has been marked as a duplicate of this bug. ***
Created attachment 67026 [details] [review] Better patch that actually works The patch fixes the resize problem to the best of my knowledge. I did change a few things. First, when resizing the window, the sidebar will no longer scale with the window (the gtk_paned_pack2 line). This was so that the code could predict how much space the sidebar will consume. Now, when toggling the sidebar, the exact amount of width that the sidebar + pane handle use is added and subtracted so that the video widget remains the same size. Of course, the patch fixes the problem with toggling and the window doing funky things. One of the things that I did to achieve this was to realize the sidebar as soon as we set it up. This is so that we know how much space it is allocated. The patch removes most (all?) of the old patch and removes on_show_sidebar1_activate in favor of using g_signal_connect_swapped.
Your patch asserts though: GLib-GObject-WARNING **: gvalue.c:89: cannot initialize GValue with type `gint', the value has already been initialized as `-g-type-private--GTypeFlags'
+ Trace 68912
I fixed that warning, which incidentally made it work as well :) Very good patch, thanks Eric. Committed to gnome-2-14 and HEAD. 2006-06-18 Bastien Nocera <hadess@hadess.net> * src/totem-private.h: * src/totem-sidebar.c: (cb_resize), (on_sidebar_button_toggled), (totem_sidebar_setup): Patch from Eric Anderson <ejona86@gmail.com> to make showing and hiding the sidebar not resize the video window (Closes: #324346)
*** Bug 322614 has been marked as a duplicate of this bug. ***