Bug 324265 – crash when opening "Toolbars" dialog.

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 324265 - crash when opening "Toolbars" dialog.


Summary:	crash when opening "Toolbars" dialog.


Status:	RESOLVED FIXED

Product:	epiphany
Classification:	Core
Component:	Controls
Version:	git master
Hardware:	Other Linux

Importance:	High critical
Target Milestone:	---
Assigned To:	Epiphany Maintainers
QA Contact:	Marco Pesenti Gritti

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2005-12-16 12:58 UTC by Claudio Saavedra
Modified:	2005-12-16 16:19 UTC

See Also:
GNOME target:	---
GNOME version:	2.13/2.14

Attachments
fix (1.72 KB, patch) 2005-12-16 14:04 UTC, Claudio Saavedra	none	Details \| Review

Description Claudio Saavedra 2005-12-16 12:58:21 UTC

Edit->Toolbars.

crash!

Comment 1 Claudio Saavedra 2005-12-16 13:00:21 UTC

Backtrace was generated from '/opt/gnome2head/bin/epiphany'

Using host libthread_db library "/lib/tls/libthread_db.so.1".
`system-supplied DSO at 0xffffe000' has disappeared; keeping its symbols.
[Thread debugging using libthread_db enabled]
[New Thread -1230243616 (LWP 29668)]
[New Thread -1274012752 (LWP 29685)]
[New Thread -1265624144 (LWP 29684)]
[New Thread -1256207440 (LWP 29672)]
[New Thread -1239282768 (LWP 29671)]
0xb6df9231 in __waitpid_nocancel () from /lib/tls/libpthread.so.0

+ Trace 64643

Thread 1 (Thread -1230243616 (LWP 29668))

#0 __waitpid_nocancel
from /lib/tls/libpthread.so.0
#1 libgnomeui_segv_handle
at gnome-ui-init.c line 786
#2 <signal handler called>
#3 IA__g_logv
#4 IA__g_log
at gmessages.c line 517
#5 IA__g_return_if_fail_warning
#6 IA__gdk_cursor_new_from_pixbuf
at gdkcursor-x11.c line 619
#7 configure_item_cursor
at egg-editable-toolbar.c line 617
#8 egg_editable_toolbar_set_edit_mode
at egg-editable-toolbar.c line 1427
#9 ephy_toolbar_editor_constructor
at ephy-toolbar-editor.c line 299
#10 IA__g_object_newv
at gobject.c line 910
#11 IA__g_object_new_valist
at gobject.c line 994
#12 IA__g_object_new
at gobject.c line 791
#13 ephy_toolbar_editor_show
at ephy-toolbar-editor.c line 407
#14 window_cmd_edit_toolbar
at window-commands.c line 705
#15 IA__g_cclosure_marshal_VOID__VOID
at gmarshal.c line 77
#16 IA__g_closure_invoke
at gclosure.c line 490
#17 signal_emit_unlocked_R
at gsignal.c line 2449
#18 IA__g_signal_emit_valist
at gsignal.c line 2208
#19 IA__g_signal_emit
at gsignal.c line 2252
#20 _gtk_action_emit_activate
at gtkaction.c line 1042
#21 IA__gtk_action_activate
at gtkaction.c line 1069
#22 IA__g_cclosure_marshal_VOID__VOID
at gmarshal.c line 77
#23 IA__g_closure_invoke
at gclosure.c line 490
#24 signal_emit_unlocked_R
at gsignal.c line 2449
#25 IA__g_signal_emit_valist
at gsignal.c line 2208
#26 IA__g_signal_emit
at gsignal.c line 2252
#27 IA__gtk_widget_activate
at gtkwidget.c line 3766
#28 IA__gtk_menu_shell_activate_item
at gtkmenushell.c line 1057
#29 gtk_menu_shell_button_release
at gtkmenushell.c line 663
#30 gtk_menu_button_release
at gtkmenu.c line 2571
#31 _gtk_marshal_BOOLEAN__BOXED
at gtkmarshalers.c line 83
#32 g_type_class_meta_marshal
at gclosure.c line 567
#33 IA__g_closure_invoke
at gclosure.c line 490
#34 signal_emit_unlocked_R
at gsignal.c line 2487
#35 IA__g_signal_emit_valist
at gsignal.c line 2218
#36 IA__g_signal_emit
at gsignal.c line 2252
#37 gtk_widget_event_internal
at gtkwidget.c line 3735
#38 IA__gtk_propagate_event
at gtkmain.c line 2175
#39 IA__gtk_main_do_event
at gtkmain.c line 1412
#40 gdk_event_dispatch
at gdkevents-x11.c line 2291
#41 IA__g_main_context_dispatch
at gmain.c line 1913
#42 g_main_context_iterate
at gmain.c line 2544
#43 IA__g_main_loop_run
at gmain.c line 2748
#44 IA__gtk_main
at gtkmain.c line 991
#45 main
at ephy-main.c line 312
#0 __waitpid_nocancel
from /lib/tls/libpthread.so.0

Comment 2 Claudio Saavedra 2005-12-16 14:04:42 UTC

Created attachment 56068 [details] [review]
fix

The refered image was removed and now epiphany uses a GDK stock image. Attached
patch fixes the crash.

Ok to commit?

Comment 3 Christian Persch 2005-12-16 16:10:19 UTC

Thanks for the patch, please commit!

Comment 4 Claudio Saavedra 2005-12-16 16:19:01 UTC

Fixed in HEAD:

2005-12-16  Claudio Saavedra  <csaavedra@alumnos.utalca.cl>

        * lib/egg/egg-editable-toolbar.c: (configure_item_cursor):
        Use a gtk stock cursor (GDK_HAND2) instead of already removed image.
        Fixes bug #324265.