After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 324122 - Scroll pages in page entry with mouse wheel
Scroll pages in page entry with mouse wheel
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
0.4.x
Other All
: Normal enhancement
: ---
Assigned To: Evince Maintainers
Evince Maintainers
ghop[2007-50]
Depends on:
Blocks:
 
 
Reported: 2005-12-14 21:24 UTC by Alexander “weej” Jones
Modified: 2007-12-20 22:34 UTC
See Also:
GNOME target: ---
GNOME version: 2.11/2.12


Attachments
Add scrolling to the page entry box (1.23 KB, patch)
2007-12-20 18:37 UTC, David Turner
none Details | Review
Updated patch (1.14 KB, patch)
2007-12-20 22:09 UTC, David Turner
none Details | Review
Even more updated patch (1.14 KB, patch)
2007-12-20 22:24 UTC, David Turner
committed Details | Review

Description Alexander “weej” Jones 2005-12-14 21:24:29 UTC
Lets me scroll through page numbers with my mouse-wheel, and also makes more
sense a11y-wise.

Other information:
*** This bug report was brought to you by my "Getting Linux un-fucked"
bug-filing rampage. Sorry if it seems stupid or offends. ***
Comment 1 Nickolay V. Shmyrev 2005-12-27 21:57:54 UTC
Hi Alex, not sure that we need make it real spinbox, but we can just add mouse scrolling
Comment 2 Alexander “weej” Jones 2005-12-28 01:46:47 UTC
A "spinbox" is the entry control which is just like a normal text entry but with 2 buttons to the right with an up and down arrow, yeah? Would surely be more intuitive than just a "magic" GtkEntry?
Comment 3 Nickolay V. Shmyrev 2005-12-28 06:57:58 UTC
The point is that this entry doesn't contain numbers, it shows pdf page labels instead and they can be just simple string. So presense of arrows may lead to user misunderstanding and won't look good. 
Comment 4 Martin Kretzschmar 2005-12-28 19:28:33 UTC
It used to be a spinbutton until 0.1.5. But it was removed before the support for pdf page labels was added. There must have been another reason.

2005-02-28  Marco Pesenti Gritti  <marco@gnome.org>
	[...]
	Use an entry for the page control instead of spinbuttons

Thu Mar 31 13:27:50 2005  Jonathan Blandford  <jrb@redhat.com>
	[...] Add in page label support.
Comment 5 Alexander “weej” Jones 2005-12-28 20:38:00 UTC
In reply to #3... OK I understand.

The notion of "page numbers" still applies, however. Is there no way we can neatly support both natural page numbers and PDF page labels simultaneously?

I am thinking with respect to Evince's "print preview" potential, too.
Comment 6 Wouter Bolsterlee (uws) 2006-04-24 15:23:18 UTC
So what about skipping to the next/previous page when using the scrollbar on the entry?
Comment 7 Alexander “weej” Jones 2006-06-04 23:00:36 UTC
I think that's totally voodoo myself, and would vouch against it. My previous question still remains unanswered! Why not have the best of both worlds?
Comment 8 Alexander “weej” Jones 2006-08-23 19:59:15 UTC
If PDF page labels are to be displayed in here, it seems totally out of place.

The control layout reads: [xxx  ] of yyy

If the Entry shows a PDF page label, that no longer makes sense... Not to mention the fact that the entry is only wide enough for a 6 letter word.

Bring back the SpinBox!
Comment 9 David Turner 2007-12-20 18:37:31 UTC
Created attachment 101337 [details] [review]
Add scrolling to the page entry box

Attached a patch to enable scrolling through the page entry box.
Comment 10 David Turner 2007-12-20 22:09:35 UTC
Created attachment 101360 [details] [review]
Updated patch

Updated some issues in my earlier patch
Comment 11 David Turner 2007-12-20 22:24:56 UTC
Created attachment 101361 [details] [review]
Even more updated patch

I screwed up the last patch, here's one that should work.
Comment 12 Nickolay V. Shmyrev 2007-12-20 22:34:22 UTC
Applied, thanks.