After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 324077 - PATCH: don't generate thumbnails with an alpha channel
PATCH: don't generate thumbnails with an alpha channel
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
: 345144 374339 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-12-14 15:12 UTC by Jeroen Zwartepoorte
Modified: 2006-11-13 22:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to remove the alpha component from the PDF thumbnail (182.78 KB, patch)
2005-12-16 10:15 UTC, Jeroen Zwartepoorte 		none Details | Review
screenshot (666.92 KB, image/png)
2005-12-16 10:15 UTC, Jeroen Zwartepoorte 		  Details
patch with only the relevant changes (563 bytes, patch)
2005-12-16 10:17 UTC, Jeroen Zwartepoorte 		none Details | Review
More backends to patch (2.33 KB, patch)
2005-12-16 15:08 UTC, Nickolay V. Shmyrev 		committed Details | Review

Description Jeroen Zwartepoorte 2005-12-14 15:12:50 UTC 
Nautilus HEAD doesn't add any shadowed borders any longer if the thumbnail has
an alpha channel. I've filed bugs with patches for both gnome-screenshot and
totem-video-thumbnailer (both committed). Evince is the only one left. Problem
is that evince's thumbnail code is spread accross multiple files and seems to
rely on the fact that the pixbuf is in RGBA.
Comment 1 Jeroen Zwartepoorte 2005-12-16 10:15:07 UTC 
Created attachment 56059 [details] [review]
patch to remove the alpha component from the PDF thumbnail

Attached patch removes the alpha channel from the PDF thumbnail. This make
nautilus show the thumbnail with the shadowed border again. Also, this actually
makes the thumbnail render correctly now. See the attached screenshot. On the
desktop, "ajax2-1.pdf" is thumbnailed with the above patch. In the nautilus
window the thumbnail is shown using the current code in HEAD. You'll notice the
lack of a border and also that the actual text in the thumbnail is white!
Finally there's evince itself showing the first page (with black text!). The
white text in the old thumbnail is probably somehow due to the alpha channel.
Comment 2 Jeroen Zwartepoorte 2005-12-16 10:15:42 UTC 
Created attachment 56060 [details]
screenshot
Comment 3 Jeroen Zwartepoorte 2005-12-16 10:16:30 UTC 
Note that the other backend will probably require a similar patch. This patch
only fixes the thumbnail behavior for PDFs.
Comment 4 Jeroen Zwartepoorte 2005-12-16 10:17:50 UTC 
Created attachment 56061 [details] [review]
patch with only the relevant changes
Comment 5 Nickolay V. Shmyrev 2005-12-16 14:38:24 UTC 
Isn't it better to remove alpha in thumbnailer code? Probably we'd like to have
internal thumbnails with alpha channel.
Comment 6 Nickolay V. Shmyrev 2005-12-16 15:08:47 UTC 
Created attachment 56073 [details] [review]
More backends to patch
Comment 7 Jeroen Zwartepoorte 2005-12-17 10:18:29 UTC 
Have you tried to thumbnail the various document types with the patch? I recall
seeing some that code that assumed the pixbuf had 4 channels (RGBA) instead of
just RGB. Otherwise the patch looks good.
Comment 8 Nickolay V. Shmyrev 2005-12-25 16:50:13 UTC 
Patch applied, thanks.
Comment 9 Nickolay V. Shmyrev 2006-06-24 09:38:08 UTC 
*** Bug 345144 has been marked as a duplicate of this bug. ***
Comment 10 Nickolay V. Shmyrev 2006-11-13 22:36:04 UTC 
*** Bug 374339 has been marked as a duplicate of this bug. ***