GNOME Bugzilla – Bug 323900
Basertpdepayloader lets NEWSEGMENT events through unfiltered
Last modified: 2005-12-18 01:59:58 UTC
Please describe the problem: Basertpdepayloader adds a GST-timestamp to packets it processes, based on the RTP timestamp. On the first packet, it generates a NEWSEGMENT event to notify downstream of the start-TS for this stream. In current CVS-HEAD, upstream NEWSEGMENT events are passed through the element, causing confusion to downstream elements (they get NEWSEGMENT events with different time formats). Basertpdepayloader should make sure that NEWSEGMENT events that it passes downstream, are all of the same format. Steps to reproduce: 1. 2. 3. Actual results: Expected results: Does this happen every time? Other information: A patch, hopefully attached to this bug report later on.
Created attachment 55901 [details] [review] Adds sink event filtering.
I think you should unref the NEW_SEGMENT event in gst_base_rtp_depayload_handle_sink_event() since you're dropping it.
Created attachment 55943 [details] [review] Adds sink event filtering (v2 of the patch).