After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 323878 - missing <string.h> inclusion (for memset & FD_ZERO)
missing <string.h> inclusion (for memset & FD_ZERO)
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal normal
: 0.10.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-12-12 14:15 UTC by Benjamin Pineau
Modified: 2005-12-16 11:26 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Description Benjamin Pineau 2005-12-12 14:15:09 UTC 
string.h is needed, else gsttcp won't compile on some platforms.

Index: gst/tcp/gsttcp.c
===================================================================
RCS file: /cvs/gstreamer/gst-plugins-base/gst/tcp/gsttcp.c,v
retrieving revision 1.21
diff -u -r1.21 gsttcp.c
--- gst/tcp/gsttcp.c    17 Oct 2005 13:46:22 -0000      1.21
+++ gst/tcp/gsttcp.c    12 Dec 2005 14:10:05 -0000
@@ -29,6 +29,7 @@
 #include <netinet/in.h>
 #include <arpa/inet.h>
 #include <netdb.h>
+#include <string.h>  /* memset, in FD_ZERO macro */
 #include <unistd.h>
 #include <sys/ioctl.h>

Index: gst/tcp/gsttcpclientsink.c
===================================================================
RCS file: /cvs/gstreamer/gst-plugins-base/gst/tcp/gsttcpclientsink.c,v
retrieving revision 1.16
diff -u -r1.16 gsttcpclientsink.c
--- gst/tcp/gsttcpclientsink.c  1 Dec 2005 01:21:49 -0000       1.16
+++ gst/tcp/gsttcpclientsink.c  12 Dec 2005 14:10:05 -0000
@@ -25,6 +25,7 @@
 #include <gst/dataprotocol/dataprotocol.h>
 #include "gsttcp.h"
 #include "gsttcpclientsink.h"
+#include <string.h>             /* memset */

 /* elementfactory information */
 static GstElementDetails gst_tcp_client_sink_details =
Index: gst/tcp/gsttcpserversink.c
===================================================================
RCS file: /cvs/gstreamer/gst-plugins-base/gst/tcp/gsttcpserversink.c,v
retrieving revision 1.28
diff -u -r1.28 gsttcpserversink.c
--- gst/tcp/gsttcpserversink.c  6 Dec 2005 19:41:59 -0000       1.28
+++ gst/tcp/gsttcpserversink.c  12 Dec 2005 14:10:05 -0000
@@ -29,6 +29,7 @@
 #include "config.h"
 #endif
 #include <gst/gst-i18n-plugin.h>
+#include <string.h>             /* memset */

 #include <sys/ioctl.h>

Index: gst/tcp/gsttcpserversrc.c
===================================================================
RCS file: /cvs/gstreamer/gst-plugins-base/gst/tcp/gsttcpserversrc.c,v
retrieving revision 1.27
diff -u -r1.27 gsttcpserversrc.c
--- gst/tcp/gsttcpserversrc.c   6 Dec 2005 19:41:59 -0000       1.27
+++ gst/tcp/gsttcpserversrc.c   12 Dec 2005 14:10:06 -0000
@@ -26,6 +26,7 @@
 #include <gst/gst-i18n-plugin.h>
 #include "gsttcp.h"
 #include "gsttcpserversrc.h"
+#include <string.h>             /* memset */
 #include <unistd.h>
 #include <sys/ioctl.h>
 #include <fcntl.h>
Comment 1 Tim-Philipp Müller 2005-12-16 11:26:19 UTC 
Applied, thanks!

2005-12-16  Tim-Philipp Müller  <tim at centricular dot net>

        * gst/tcp/gsttcp.c:
        * gst/tcp/gsttcpclientsink.c:
        * gst/tcp/gsttcpserversink.c:
        * gst/tcp/gsttcpserversrc.c:
          Add <string.h> includes for memset and FD_ZERO (fixes #323878;
          patch by: Benjamin Pineau).