Created attachment 55871 [details] [review]
possbile cleanups

They all seem reasonable to me.  A couple of notes though:
1. yelp-cache: this is initialised in yelp-base once and then forgotten.  Can
this be remove from the compile?
2. The stuff in yelp-io-channel will result in a compile time warning:
yelp-io-channel.c:62: warning: initialization from incompatible pointer type
as this is used to replace a g_io_channel function that expects gsize instead of
gssize.  Maybe just remove the < 0 check
3. yelp-main.c: /* Already declared as CORBA_Object above? */ - It is.  The
variable redeclaration can be removed and it still works.  The extra compile
time warning can be removed by casting:
-   factory = bonobo_generic_factory_new
+   factory = (CORBA_Object) bonobo_generic_factory_new

4. yelp-window.c: You missed a stray }; at the end of window_copy_link_cb (Just
above the 2 that you have changed)

I've committed most of the changes since they are all pretty trivial.

The io_channel stuff I created a new local variable, read into that and used that as the basis for finding the return value.

Closing:

2006-01-08  Don Scorgie  <dscorgie@cvs.gnome.org>

	* src/yelp-io-channel.c: 
	* src/yelp-xslt-pager.c: 
	* src/yelp-window.c: 
	* src/yelp-utils.c: 
	* src/yelp-toc-pager.c: 
	* src/yelp-settings.c: 
	* src/yelp-main.c: 
	* src/yelp-db-pager.c: 
	* src/yelp-bookmarks.c: 
	* src/yelp-base.c: 
	Various bits of cleanup from Kjartan Maraas (bug #323822)