After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 323664 - gnome-bluetooth-manager - startup crash.
gnome-bluetooth-manager - startup crash.
Status: RESOLVED FIXED
Product: gnome-bluetooth
Classification: Core
Component: general
0.7.x
Other All
: High critical
: ---
Assigned To: Edd Dumbill
Edd Dumbill
: 332345 333913 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-12-09 20:20 UTC by Joshua Schmidlkofer
Modified: 2006-03-27 22:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to add support for looking in $(datadir)/../pixmaps for icons (727 bytes, patch)
2006-02-02 18:53 UTC, Rodney Dawes 		committed Details | Review

Description Joshua Schmidlkofer 2005-12-09 20:20:49 UTC 
Steps to reproduce:
1. Install gnome-bluetooth 0.7.0 [http://bugs.gentoo.org/show_bug.cgi?id=113497]
2. Run gnome-bluetooth-manager
3. Crash w/ TypeError

Stack trace:
Traceback (most recent call last):

+ Trace 64512

  • File "/usr/lib/python2.4/site-packages/gnomebt/manager.py", line 274 in ? 
    BTManager ().main ()
  • File "/usr/lib/python2.4/site-packages/gnomebt/manager.py", line 78 in __init__ 
    self.setup_gui ()
  • File "/usr/lib/python2.4/site-packages/gnomebt/manager.py", line 103 in setup_gui 
    window_icon = gtk.gdk.pixbuf_new_from_file (window_icon_name)
TypeError: pixbuf_new_from_file() argument 1 must be string, not None 


Other information:
net-wireless/libbtctl-0.6.0
net-wireless/gnome-bluetooth-0.7.0
dev-python/pygtk-2.8.2
media-libs/gdk-pixbuf-0.22.0-r5
x11-libs/gtk+-2.8.8
Comment 1 Joshua Schmidlkofer 2005-12-09 21:46:08 UTC 
BTW, not knowing how to _fix_ it, I commented it out.
Comment 2 Jorge Pérez Burgos 2005-12-16 16:29:47 UTC 
I think patch in bug 323170 fixes this error.
Comment 3 Bastien Nocera 2005-12-27 19:07:18 UTC 
--- python/manager.py	7 Aug 2005 16:51:50 -0000	1.15
+++ python/manager.py	16 Dec 2005 16:21:35 -0000
@@ -265,7 +265,7 @@ class BTManager (object):
         dialog.show ()
 
     def image_file (self, fname):
-        for d in [os.path.join (__datadir__, "pixmaps"), "../pixmaps"]:
+        for d in [os.path.join (__datadir__, "pixmaps"), os.path.join (__datadir__, "../pixmaps")]:
             if os.path.isfile (os.path.join (d, fname)):
                 return os.path.join (d, fname)
         return None


That's not right. "../pixmaps" is for when manager.py is being run from source.
And in pixmaps/Makefile.am:
icondir = $(datadir)/pixmaps
icon_DATA = blueradio-48.png

So blueradio-48.png should have been installed in __datadir__, "pixmaps"

Joshua, could you check whether $(datadir)/pixmaps/blueradio-48.png exists?
Comment 4 JP Rosevear 2006-01-17 14:37:09 UTC 
It exists for me.

jpr@castle:~> rpm -ql gnome-bluetooth | grep blueradio
/opt/gnome/share/gnome-bluetooth/pixmaps/blueradio.png
/opt/gnome/share/gnome-bluetooth/pixmaps/blueradio.svg
/opt/gnome/share/pixmaps/blueradio-48.png
Comment 5 Rodney Dawes 2006-02-02 18:53:04 UTC 
Created attachment 58599 [details] [review]
Patch to add support for looking in $(datadir)/../pixmaps for icons

This patch, rather than replace "../pixmaps", simply adds another path before it, which is the result of joining __datadir__ and "../pixmaps", so that the global share/pixmaps directory in the prefix of installation, is also looked in for blueradio-48.png.
Comment 6 Rodney Dawes 2006-02-09 22:10:32 UTC 
Edd or Bastien, any chance I could commit this patch?
Comment 7 Bastien Nocera 2006-02-09 22:56:53 UTC 
You're right. For some reason I thought __datadir__ would be set to $(datadir), and not $(datadir)/gnome-bluetooth which it is in defs.py
Comment 8 Rodney Dawes 2006-02-10 19:11:06 UTC 
Committed to HEAD just now. Thanks.
Comment 9 Bastien Nocera 2006-03-27 22:29:17 UTC 
*** Bug 333913 has been marked as a duplicate of this bug. ***
Comment 10 Bastien Nocera 2006-03-27 22:40:20 UTC 
*** Bug 332345 has been marked as a duplicate of this bug. ***