After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 323483 - missing API functions
missing API functions
Status: RESOLVED WONTFIX
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.10.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-12-07 16:30 UTC by Wim Taymans
Modified: 2006-02-13 12:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Wim Taymans 2005-12-07 16:30:55 UTC 
GstMiniObject::_ref, _unref, _replace, _copy, _is_writable, _make_writable

Exiting macros in subclasses to these methods:

GstBuffer::_ref, _unref, _replace, _copy, _is_writable, _make_writable
GstEvent::_ref, _unref, _copy
GstQuery::_ref, _unref, _copy, _make_writable
GstMessage::_ref, _unref, _copy, _make_writable

For the GValue stuff:

GstMiniObject::_set, _take, _get

Macros:

GstBuffer::_set, _take, _get
GstEvent::
GstQuery::
GstMessage::

Should we be consistent and provide macros for all these methods?
Comment 1 Jan Schmidt 2005-12-07 16:37:35 UTC 
ok, so this is about adding API to provide macros for all of _ref, _unref,
_replace, _copy, _is_writable, _make_writable  in each of the subclasses. I
think that sounds like a dandy idea.
Comment 2 Jan Schmidt 2006-02-09 22:34:33 UTC 
So far noone seems to be missing this API. Is it still worth adding?
Comment 3 Edward Hervey 2006-02-10 08:47:09 UTC 
the _set/_get/_take methods are used much less often than the refcount-related methods.

The point of convenience macros, IMHO, is for features that are used a lot... so I'd be in favour of NOT adding them.
Comment 4 Wim Taymans 2006-02-13 12:04:57 UTC 
closing, idea is to add API when needed.