GNOME Bugzilla – Bug 323471
[PLUGIN-MOVE] osxaudio
Last modified: 2007-03-15 11:41:06 UTC
Please describe the problem: It looks like osxaudiosink and osxvideoslink are in gst-plugins-good in CVS HEAD, just not referenced in the Makefile.am, and they're not in the final 0.10.0 tarball. Is this an oversight, or is there something actually wrong with these plugins? Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
They haven't been ported yet to 0.10.
osxaudiosink and osxaudiosrc have been ported and now work better than the 0.8 versions. They are however not yet enabled in the build as there is still things I want to improve on them. osxvideosink i am in middle of porting.
Awesome, thanks! If you need any help testing, I've got access to 10.3/ppc, 10.4/ppc, and 10.4/intel boxes. Just let me know what to try building. :)
Thanks, I confirmed over the weekend that osxaudiosink works on 10.4/intel. Before I had only tested on 10.4/ppc. Also should not be too long before osxvideosink is working.
Zaheer, could you attach your pending patches here ?
osxvideosink has been ported, it's now available in gst-plugins-bad. I'm working on cleaning up minor issues with osxaudiosink so that it can go in -good.
Created attachment 84577 [details] [review] patch for osxaudio Patch for osxaudio in -good. Adds: * proper build setup (configure.ac / Makefile.am) * documentation * debug statement fixes * last fixes for ringbuffer
the patch above fixes all known issues, and fulfills the requirements for having the osxaudio plugin in good. Could somebody please review it so we can commit it ?
I will review it.
Looks good.
2007-03-15 Edward Hervey <edward@fluendo.com> * configure.ac: * sys/Makefile.am: * sys/osxaudio/Makefile.am: * sys/osxaudio/gstosxaudio.c: * sys/osxaudio/gstosxaudiosink.c: (gst_osx_audio_sink_osxelement_do_init), (gst_osx_audio_sink_init), (gst_osx_audio_sink_getcaps), (gst_osx_audio_sink_create_ringbuffer), (plugin_init): * sys/osxaudio/gstosxaudiosrc.c: (gst_osx_audio_src_osxelement_do_init), (gst_osx_audio_src_init), (gst_osx_audio_src_create_ringbuffer): * sys/osxaudio/gstosxringbuffer.c: (gst_osx_ring_buffer_get_type), (gst_osx_ring_buffer_class_init), (gst_osx_ring_buffer_init), (gst_osx_ring_buffer_acquire), (gst_osx_ring_buffer_start), (gst_osx_ring_buffer_pause), (gst_osx_ring_buffer_stop): * sys/osxaudio/gstosxringbuffer.h: Activate osxaudio in gst-plugins-good with proper build setup. Add inlined documentation. Fix debug statements Fix ringbuffer when pausing. Fixes #323471