After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 323429 - Automatic scrolling during selection
Automatic scrolling during selection
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
0.4.x
Other All
: Normal minor
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-12-07 05:44 UTC by Ken Harris
Modified: 2005-12-27 07:56 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10


Attachments
add automatic scroll (964 bytes, patch)
2005-12-24 01:33 UTC, Ricardo Markiewicz
none Details | Review

Description Ken Harris 2005-12-07 05:44:30 UTC
In most applications, if you press the mouse button (to start selecting), and
drag it out of the window, the contents of the window scroll, so you can easily
select things larger than the window.

Evince doesn't do this, but should.

Other information:
Comment 1 Nickolay V. Shmyrev 2005-12-21 14:27:29 UTC
It would be nice to have a patch
Comment 2 Ricardo Markiewicz 2005-12-24 01:33:08 UTC
Created attachment 56346 [details] [review]
add automatic scroll

This patch add the automatic scrolling during selection. This works for me, but I'm not sure if there this is the best place to add this feature. Please let me know.

Fri Dec 23 22:29:00 2005  Ricardo Markiewicz  <rmarkie@fi.uba.ar>

  * shell/ev-view.c: Close bug #323429 :
  Automatic scrolling during selection
Comment 3 Nickolay V. Shmyrev 2005-12-25 13:30:13 UTC
Thanks Ricardo for doing this work, really nice patch. I've just modified it a bit  and committed. Also there is minor trouble that you should not set adjustment to upper value, maximum value should be (upper - page_size) instead. If you are interesed in another easy fix bug, just ask.
Comment 4 Ken Harris 2005-12-25 23:16:50 UTC
Thanks for working on this, everybody!

Two comments:
- It looks like the committed patch scrolls at a rate proportionate to the distance outside of the viewport you've moved the mouse (right?), which is good
- It appears to scroll in the y-direction only; remember that you can scroll in the x-direction, too

Adding horizontal scrolling looks very straightforward (just update selection_scroll_timeout_cb to deal with x-coordinates).
Comment 5 Nickolay V. Shmyrev 2005-12-27 07:56:30 UTC
Yeah, forgot about horizontal scroll :( Its fixed in CVS also.