After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 323364 - Add tracks to playlist with menu
Add tracks to playlist with menu
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: User Interface
0.9.x
Other All
: Normal enhancement
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 341871 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-12-06 11:17 UTC by Baptiste Mille-Mathias
Modified: 2006-06-07 19:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (15.33 KB, patch)
2006-03-27 13:51 UTC, James "Doc" Livingston
none Details | Review
updated patch (15.37 KB, patch)
2006-04-16 08:00 UTC, James "Doc" Livingston
none Details | Review
updated patch (15.41 KB, patch)
2006-05-12 14:59 UTC, James "Doc" Livingston
committed Details | Review

Description Baptiste Mille-Mathias 2005-12-06 11:17:28 UTC
ATM this is not possible to add a track to a playlist using the menu.
I think this should be implemented, because if you can't use pointer system you
can't do this operation.
Perhaps this option should be available in the contextual menu on the track list
too ?
Comment 1 James "Doc" Livingston 2005-12-06 13:42:44 UTC
It is possible at the moment, but it's not obvious how to do it. You select
tracks, use Edit->Copy, go to the playlist you want to add them to, and use
Edit->Paste.

I agree that a more obvious way of doing it would be _much_ better.
Comment 2 Keith 2006-03-13 00:41:09 UTC
I don't know if this would bee the same bug or not, but feel free to move this if it should be separate.  I have a Cowon IAudio M5 andhave used the patch for CVS to get it to recogize it (which is working) but it does not play any of the playlists (audacious can play them if it made the playlist.)  I can not make playlists on the M5 with Rhythmbox. It will not let me copy and paste tracks to playlist, or make a playlist using "new automatic playlist".  I don't know if this a permissions problem or not (I don't think it is because other prgrams (audacious) can write playlists to the IAudio, and also play them.  Don't know if any other PMP is having this problem.
Comment 3 James "Doc" Livingston 2006-03-14 10:39:35 UTC
Keith: Rhythmbox doesn't (yet) have support for writing playlists to any audio players, just reading them. There is are bugs filed for playlist support on several different Cowon players.
Comment 4 James "Doc" Livingston 2006-03-27 13:51:58 UTC
Created attachment 62124 [details] [review]
patch

There are a couple of bugs to iron out, but it mostly works for me.

* something steals the sourcelist focus when it starts to let you rename the new playlist you have just created
* should "add to queue" be put in the submenu too? probably not, since it's conceptually different than a playlist
Comment 5 James "Doc" Livingston 2006-04-16 08:00:55 UTC
Created attachment 63624 [details] [review]
updated patch

Updated for cvs.
Comment 6 James "Doc" Livingston 2006-05-12 14:59:40 UTC
Created attachment 65318 [details] [review]
updated patch

Updated to CVS.

Does anyone have an option on whether this is good, should to turned into a plugin (fairly simple), or is useless?
Comment 7 Alex Lancaster 2006-05-12 15:20:21 UTC
(In reply to comment #6)

> Does anyone have an option on whether this is good, should to turned into a
> plugin (fairly simple), or is useless?
 
It works, except that for some reason my CPU usage shoots sky high after I apply the patch.  If I back it out, it works fine again.

I think it's an excellent feature, and I'd be happy for it to be in core rhythmbox.  It makes it much easier to create playlists more quickly without drag and drop, or cut and paste because it can be done via keyboard and/or accessibility keys.
Comment 8 James "Doc" Livingston 2006-05-20 04:54:16 UTC
Committed to cvs with a fix for the CPU issue, and correctly removing menu items when playlists are deleted.
Comment 9 William Jon McCann 2006-06-07 19:59:08 UTC
*** Bug 341871 has been marked as a duplicate of this bug. ***