GNOME Bugzilla – Bug 323346
Gdm needs option to set nice priority for X server
Last modified: 2005-12-21 02:22:57 UTC
Distribution/Version: FC3 An option is needed in the gdm.conf file to specify what nice level the X server should run at. This is especially useful in environments where the X server needs to be more responsible to interactive users.
Created attachment 55700 [details] [review] Proposed patch Tested, and it seems to work. We could test the value of "priority" when we parse it, but the call to setpriority() is going to check the boundaries anyway.
Created attachment 55702 [details] [review] Additional patch for template config Might as well include info in the config as to how to change the default priority.
This patch is against the 2.8 (aka 2.12) branch. The way configuration is handled in CVS head is quite different, and it is only appropriate to add such a new configuration option to CVS head. Please regenerate the patch for CVS head. Also the docs in docs/C/gdm.xml need to be updated with the new configuration option.
Ummm... Ok. I'll try. (a) Is CVS working? Looking at the website, it doesn't seem to be, and grabbing all of the files via viewcvs would be tedious. (b) Is there a .spec that works with FC3 that I can build from? This would make testing quicker.
Did you follow instructions here: http://developer.gnome.org/tools/cvs.html You could base a patch on the latest release of 2.13.0.2 and that would apply to CVS head (the only files that have been modified in CVS head since then is gdmsetup.c, gui/gdmsetup.glade. I don't think your patch modifies these files, so that shouldn't be a problem. There has been a minor change to daemon/gdm.h in CVS head but just a minor update to comments that I can merge if necessary. So base your patch on 2.13.0.2 and I'll take care of getting it into CVS. The default value of the new feature should be "0" and defined so that the priority is not set when given this value. Make sure the docs in gdm.conf and the docs/C/gdm.xml clearly explain how this works. I won't accept a patch that adds a new config option without documentation. Also note the comments in daemon/gdm.h that explain what is expected from someone providing a patch that adds a new configuration option,
Created attachment 56194 [details] [review] Patch ported to 2.13.0.4 This patch also includes minor fixes for: * gui/misc.c not compiling * missing requirements for gtk2 version 2.6.0 or later * fixed Makefiles in gui/ to specify correct include directory for X11 libs
Committed to CVS head. Thanks!