After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 323341 - ./autogen.sh enchancement for ease of use on FreeBSD
./autogen.sh enchancement for ease of use on FreeBSD
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: General
git master
Other FreeBSD
: Normal enhancement
: 2.4
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2005-12-06 04:38 UTC by Pierre-Paul Lavoie
Modified: 2005-12-07 01:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch for autogen.sh (2.69 KB, patch)
2005-12-06 04:39 UTC, Pierre-Paul Lavoie
rejected Details | Review
Better patch (1.99 KB, patch)
2005-12-06 16:07 UTC, Pierre-Paul Lavoie
committed Details | Review

Description Pierre-Paul Lavoie 2005-12-06 04:38:32 UTC
In autogen.sh, use symbolic variables like

ACLOCAL=aclocal
AUTOCONF=autoconf
AUTOHEADER=autoheader
AUTOMAKE=automake
LIBTOOLISE=libtoolize

instead of directly calling the executable. It makes it easier for platforms
with less-common executable names (such as FreeBSD). You can change everything
in one place. This method is fairly common.

See patch in attachement.
Comment 1 Pierre-Paul Lavoie 2005-12-06 04:39:13 UTC
Created attachment 55668 [details] [review]
Patch for autogen.sh
Comment 2 Sven Neumann 2005-12-06 11:40:25 UTC
This patch changes the behaviour of autogen.sh and I don't see a reason to do
such a change. Actually, I don't see a need for any changes to autogen.sh. It's
just a convenience script and people with uncommon environments are free to
follow the instructions in HACKING and call the build tools manually. IMO the
real fix here is to install proper symlinks on your FreeBSD system.

Not going to apply this patch, but I would accept a less intrusive patch that
keeps the current behaviour of preferring automake-1.9 and exiting with proper
error codes.
Comment 3 Pierre-Paul Lavoie 2005-12-06 16:06:08 UTC
You're right. It does change the lookup order for automake executables. I'll
attach a cleaner patch which affect fewer lines. It will only introduce the
symbolic names idea and will check for user-given executable names after looking
at the proposed automake-1.9 name.

The main goal is to add the convenience of being able to provide alternative
names without being required to manually edit every occurence of that names in
autogen.sh.

P.S. Normally, the user-given executable names should override anything else.
The prefered names should be put in the symbolic name as default.
Comment 4 Pierre-Paul Lavoie 2005-12-06 16:07:51 UTC
Created attachment 55691 [details] [review]
Better patch

In response to comment #2.
Comment 5 Sven Neumann 2005-12-06 17:18:26 UTC
2005-12-06  Sven Neumann  <sven@gimp.org>

	* autogen.sh: applied a patch provided by Pierre-Paul Lavoie that
	makes it easier to adapt autogen.sh to uncommon executable names
	(bug #323341).

Comment 6 Manish Singh 2005-12-07 01:15:32 UTC
Further tweaks:

2005-12-06  Manish Singh  <yosh@gimp.org>

        * autogen.sh: Allow overriding from shell environment variables,
        and prefer any overrid automakes to the default, so long as the
        version is new enough.