GNOME Bugzilla – Bug 323237
several HIG fixes for f-spot dialogs
Last modified: 2007-08-31 07:41:37 UTC
this adds some borders around create tag, preferences and set date range dialogs so that they complain better with the HIG (12 pixels) I also made the task bar skip modal dialogs. Hope it is useful, the modifed dialogs look a lot better to me.
Created attachment 55616 [details] [review] patch for some dialogs
Using this patch, the dialogs you changed now have very large borders between the edge of the window and widgets within them. Measuring things with the Gimp, none seem to be closer than 22px from the edge. Any idea why this is? Is it because the Alignments you also set? Thanks for the patch!
Any update here?
ok, i found some time and redid the preferences dialog in head i also added some spacings here and there. I'm no UI expert but there are several dialogs in this new version that look specially ugly, for example the adjust time dialog is plain ugly.
Created attachment 59144 [details] [review] v2 patch
Can you add a ChangeLog entry so it's easier to tell what you changed? It is known that the adjust time dialog needs a lot of work, and it's being done. Thanks.
ok, here we go i hope it is ok this time. The patch is redone against CVS HEAD
Created attachment 60335 [details] [review] v3 patch
ping?
Gabriel, Larry? Any comments on this one?
This patch is now part of Goal #3, and hopefully will be accepted in two weeks time.
Comment on attachment 60335 [details] [review] v3 patch marking this as a patch
I don't have time to check every single dialog this patch changes, but I did check one in depth. I checked the "Set Date" dialog. Quite simply, this patch results in about as broken of a dialog as the original. Specifically, the distance between the left border and the top-left text ("Start") is supposed to be 12, but in the orig it is 11 and with this patch it is 23. From the top border to that text should be 12 too, orig is 6, patch is 18. Right border to date entry widget should be 12, orig 7, patch 19. OK button is still 10 px from right/bottom border when it should be 12. I have no idea where the disconnect is here, but this patch appears to be way off what is needed. I think we should focus on fixing one dialog at a time instead of one giant patch for many dialogs. To start with, let's focus on the "Set Date" dialog. I'll try to come up with a patch that I think fixes it.
Diego, can you provide a patch for each dialog ? so we can review and discuss them one by one ?
Right now i can't do it, I started working and my free time is quite limited already. Besides i lost all my interest in this bug and f-spot in general, I went back to gthumb and eog due to several problems.
closing as obsolete...