After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 323057 - Make podcast support a plugin
Make podcast support a plugin
Status: RESOLVED OBSOLETE
Product: rhythmbox
Classification: Other
Component: Podcast
0.9.x
Other All
: Normal enhancement
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 655198 672355 (view as bug list)
Depends on: 431846 432575
Blocks:
 
 
Reported: 2005-12-02 20:38 UTC by pavel
Modified: 2018-05-24 10:55 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Attachments
Fix a bug in the python bindings for do_impl_get_search_actions (720 bytes, patch)
2007-04-20 13:42 UTC, Tim Retout
none Details | Review
Fix up property_view_new in rb.defs (538 bytes, patch)
2007-04-20 23:39 UTC, Tim Retout
none Details | Review
Work in progress podcast plugin. (16.99 KB, application/x-compressed-tar)
2007-04-21 13:19 UTC, Tim Retout
  Details
Podcast plugin version 0.2 (6.27 KB, application/x-compressed-tar)
2007-04-23 12:44 UTC, Tim Retout
  Details

Description pavel 2005-12-02 20:38:22 UTC
Version details: 0.9.2
Distribution/Version: Ubuntu Dapper

dont display the radio/podcasts sources in the source list, if there are no
entries for them, since it is only a waste of space and probably confuses users.
Once the User has added a station/ feed, the corresponding item can be displayed
again.
Comment 1 Baptiste Mille-Mathias 2006-02-01 21:55:03 UTC
I think 'hide the sources when empty' could make these features more diffcult to discover by users.
I would recommand to have an option to hide these sources on request if for instance you don't use them.
Comment 2 James "Doc" Livingston 2006-06-04 10:39:58 UTC
This will happen when podcast and iradio support get turned into (on by default) plugins. Retitling and changing component.
Comment 3 William Jon McCann 2006-07-10 14:21:49 UTC
Also bug #347097 for iradio plugin.
Comment 4 Tim Retout 2006-10-26 14:23:34 UTC
I would quite like to implement this; I have begun writing a plugin in python, using 'feedparser', as suggested[0] on the rhythmbox-devel mailing list in July.

[0] http://mail.gnome.org/archives/rhythmbox-devel/2006-July/msg00019.html

No meaningful patch yet, though. Hope I'm not duplicating effort.
Comment 5 Alex Lancaster 2007-03-14 01:03:33 UTC
Here is the feedparser URL: http://feedparser.org/
Comment 6 Tim Retout 2007-04-20 13:42:54 UTC
Created attachment 86691 [details] [review]
Fix a bug in the python bindings for do_impl_get_search_actions

Copies what do_impl_get_ui_actions does. No currently existing plugin uses this function afaik, so the bug's not been noticed.
Comment 7 Tim Retout 2007-04-20 23:39:29 UTC
Created attachment 86720 [details] [review]
Fix up property_view_new in rb.defs

Another bit no one else seems to use yet.
Comment 8 Tim Retout 2007-04-21 13:19:02 UTC
Created attachment 86739 [details]
Work in progress podcast plugin.

This is a snapshot of where I've got to - it's pretty much a direct translation from C into Python. Most of the GUI is implemented, although the append_column_custom() method of RBEntryView needs binding (which could be tricky, as it involves a function pointer). Feeds aren't listed (see bug #431846), but other rhythmdb queries work. Currently it's using the podcast support that's hardcoded into rhythmdb.

So far, the PodcastManager class is just a stub.
Comment 9 Christophe Fergeau 2007-04-21 20:15:48 UTC
Is it worth rewriting the whole podcast code from C to python just to make it a plugin? WOuldn't it be easier to just change the existing C code to turn it into a (C) plugin?
Comment 10 Tim Retout 2007-04-21 22:06:14 UTC
I'm hoping to replace the SAX parser with an external Python library, 'feedparser', which will fix a lot of other podcast-related bugs. Along the way, this should make the Python bindings more powerful.

It would be possible to do a C plugin first, but imho it doesn't gain you much, apart from being able to hide the source.
Comment 11 Hubert Figuiere (:hub) 2007-04-23 12:39:34 UTC
Isn't there a feed parser library that could be used without bloating with
python? liferea for example has a feed parser. And at least would share the
bugs... and the fixes.
Comment 12 Tim Retout 2007-04-23 12:44:26 UTC
Created attachment 86838 [details]
Podcast plugin version 0.2

- Put source icon in right place. Remove data directory.
- Don't use gobject.new() for source constructor, simplifying things greatly.
- Remove shutdown() and add_feed().
- Add more columns to entry view (depends on a fix to bug #432318, coming soon once cleaned up).

The previous patches have been obsoleted in favour of fixes to bug #432575 and bug #432228.
Comment 13 Jeff Craig 2007-09-28 16:28:39 UTC
What's the status on this?  Are you still working on this Tim?
Comment 14 Jonathan Matthew 2011-07-24 08:42:32 UTC
*** Bug 655198 has been marked as a duplicate of this bug. ***
Comment 15 Jonathan Matthew 2012-03-18 20:58:48 UTC
*** Bug 672355 has been marked as a duplicate of this bug. ***
Comment 16 GNOME Infrastructure Team 2018-05-24 10:55:56 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/97.