GNOME Bugzilla – Bug 322957
Show "Network Servers" icon in the desktop directly
Last modified: 2005-12-10 11:30:50 UTC
Right now we have a "Network Servers" item in the Places menu in the panel. We ran some usability tests at Novell and it turns out that users would prefer to have an icon like Windows's "Network Neighborhood" directly in the desktop. The attached patch implements this, but I'm not totally satisfied with it: - An item for "Network Servers" does not appear in the Places sidebar. I'd like to have this in GtkFileChooser as well, via GtkFileSystemGnomeVFS. - An item for "Network Servers" does not appear in the Go menu in Nautilus windows. So, I'm wondering if we need a magic "network:///" volume that is always present , courtesy of GnomeVFSVolumeMonitor. This would make it appear in GtkFileSystemGnomeVFS and probably the Nautilus Places sidebar as well.
Created attachment 55493 [details] [review] nautilus-322957-network-servers-desktop-icon.diff
*** Bug 160478 has been marked as a duplicate of this bug. ***
Hi! I just filed Bug 323676 on a related issue: namely that Network-related things shouldn't really be in Computer. A Windows-like Network Neighborhood would surely be a real win, good to hear your usability tests confirm this. But one of the things it should have is all of the network places gathered in one place - regardless of them being SMB/NFS or FTP and such. Perhaps this is subject to yet another bug though...
*** Bug 323676 has been marked as a duplicate of this bug. ***
I've taken the liberty of marking bug #323767 as a duplicate of this one, since they describe the same thing. Also, I just committed the patch to HEAD, per Alex's approval on the mailing list: http://mail.gnome.org/archives/nautilus-list/2005-December/msg00027.html 2005-12-09 Federico Mena Quintero <federico@ximian.com> Fixes bug #322957: Add a "Network Servers" icon on the desktop, which takes you to network:/// * libnautilus-private/nautilus-global-preferences.h (NAUTILUS_PREFERENCES_DESKTOP_NETWORK_VISIBLE): New preference name. This determines whether we show the "Network Servers" icon. * libnautilus-private/apps_nautilus_preferences.schemas.in: Add a schema for /apps/nautilus/desktop/network_visible; the default is true. * libnautilus-private/nautilus-desktop-link.h (NautilusDesktopLinkType): Add a NAUTILUS_DESKTOP_LINK_NETWORK type. * libnautilus-private/nautilus-desktop-link.c (nautilus_desktop_link_new): Support NAUTILUS_DESKTOP_LINK_NETWORK. * libnautilus-private/nautilus-desktop-link-monitor.c (NautilusDesktopLinkMonitorDetails): Added a network_link field. (nautilus_desktop_link_monitor_delete_link): Don't delete NAUTILUS_DESKTOP_LINK_NETWORK links. (update_link_visibility): New helper function. (desktop_home_visible_changed): Use update_link_visibility(), to avoid duplicated code. (desktop_computer_visible_changed): Likewise. (desktop_trash_visible_changed): Likewise. (desktop_network_visible_changed): New function. (create_link_and_add_preference): New helper function. (nautilus_desktop_link_monitor_init): Use create_link_and_add_preference() to avoid duplicated code. Also, create the network_link. (desktop_link_monitor_finalize): Unref the network_link. (remove_link_and_preference): New helper function. (desktop_link_monitor_finalize): Use remove_link_and_preference() to avoid duplicated code. Also, free the network_link. * src/file-manager/fm-icon-container.c (SortCategory): Add a SORT_NETWORK_LINK category right before SORT_MOUNT_LINK, so that the "Network Servers" icon appears before mounts. (get_sort_category): Use SORT_NETWORK_LINK as the category for NAUTILUS_DESKTOP_LINK_NETWORK.
Well, it was not entirely what that bug described. In that bug, I also requested that all network mounts be removed from Computer, not only the network:/// folder, but also the FTP shares that recide directly in Computer. I would like all network-related places to be in the network:/// folder, that will now be placed at the desktop.