GNOME Bugzilla – Bug 322926
FileChooser: Alt-Shift-Down should work like Alt-Down
Last modified: 2011-01-29 11:00:01 UTC
In the file chooser, I can open a folder with Alt-Down. It does that to be like Nautilus. In Nautilus, I can also do Alt-Shift-Down to open-and-close-the-current-folder. I know close-the-current-folder. wouldn't be meaningful in the FileChooser, but I think it would make sense for Alt-Shift-Down to do exactly the same as Alt-Down, instead of nothing.
This is easy to fix. Care to give us a patch? :)
Created attachment 179433 [details] [review] Do the same thing as ALT-Down when getting ALT-SHIFT-Down From what I understand this patch is all that's needed. Any particular documentation that should be updated with this ?
Wait... this bug could be obsolete somehow. It seems this is based on an old filechooser implementation. Currently ALT-Up/Down are used to navigate the depth of the GtkPathBar in the top section of the filechooser. Not sure what should be done with this, should we just close this ?
(In reply to comment #3) > Wait... this bug could be obsolete somehow. > > It seems this is based on an old filechooser implementation. > > Currently ALT-Up/Down are used to navigate the depth > of the GtkPathBar in the top section of the filechooser. Well, that's almost the same thing, right? It doesn't open folders that are not in the path already, but it's close. I guess that Alt-Shift-Up/Down should still do the same as Alt-Up/Down. That I can no longer use these to open a folder, like I can in Nautilus, would be another bug.
Please commit your patch with a little change: Can you please add an function add_normal_and_shifted_binding(binding_set, key, mods, "signal-name")? And then from class_init() just call add_normal_and_shifted_binding (binding_set, GDK_Up, GDK_MOD1_MASK, "up-folder"); add_normal_and_shifted_binding (binding_set, GDK_KP_UP, GDK_MOD1_MASK, "up-folder"); and likewise for the down-folder ones. The relevant docs are in gtkfilechooser.c - grep in it for "up-folder"; there's a big-ass docstring in there somewhere :) Thanks!
Created attachment 179491 [details] [review] Add shifted bindings for "folder-up" and "folder-down" Ok this one updates the documentation and adds the shifted modifiers for "folder-up"/"folder-down" by adding a convenience function as Federico requested. Ok to commit ?
Review of attachment 179491 [details] [review]: Looks fine to me
Review of attachment 179491 [details] [review]: Perfect :) Please go ahead and commit.
Thanks, pushed.