GNOME Bugzilla – Bug 322907
Modified settings should be ignored after a Error message in Pilot Settings->Device Settings
Last modified: 2006-03-10 09:33:09 UTC
Please describe the problem: Using Gnome-Pilot pkg for Solaris USB port on x86 platform. When select Type as Serial in Pilot Settings -> Device Settings , a Error message will display as " Read/Write permissions failed on Cradle(the Port you select, such as /dev/pilot) Check the permissions on the device and retry ". Then the modified settings are saved all the same in Device Settings,although it shouldn't be stored. Steps to reproduce: Actual results: Expected results: Does this happen every time? Yes Other information: Version details: gnome-pilot 2.0.13 Distribution/Version: Solaris NV 24
Created attachment 55465 [details] [review] proposed patch It works for this bug on Solaris platform
I think there's a simpler patch (next attachment), that accomplishes the same thing: just don't close the dialog until the parameter checking passes. However, on reflection there may be a problem with this approach: it prevent users from configuring a valid device that doesn't exist at configuration time. I can't test this, but I suspect this could happen if a serial device is using a USB->serial converter. Comments?
Created attachment 57201 [details] [review] alternative patch: don't close the dialog until the params are ok
Thanks for the work on this one. I've committed a patch to CVS. (the actual patch commit was the bugfixed version of the patch in comment #3. See also #328395)
Hi,Matt Can the bug be marked as resolved, since you have committed your patch for this bug. Thanks, Jerry
The bug can't be reproducible. I verified it with pilot-link-0.12.0-pre + gnome-pilot CVS.
ok, thanks. I'll mark as verified.