After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 322895 - libgnome Cygwin build fixes
libgnome Cygwin build fixes
Status: RESOLVED FIXED
Product: libgnome
Classification: Deprecated
Component: general
2.12.x
Other Cygwin
: Normal normal
: ---
Assigned To: libgnome maintainer
libgnome maintainer
Depends on:
Blocks:
 
 
Reported: 2005-12-01 02:42 UTC by Yaakov Selkowitz
Modified: 2006-12-06 19:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
libgnome-2.12.0.1 Cygwin patch (3.59 KB, patch)
2005-12-01 02:42 UTC, Yaakov Selkowitz
none Details | Review
libgnome-2.13 Cygwin patch (3.27 KB, patch)
2006-01-11 21:55 UTC, Yaakov Selkowitz
needs-work Details | Review
libgnome-2.16.0 patch (4.43 KB, patch)
2006-12-06 07:37 UTC, Yaakov Selkowitz
none Details | Review

Description Yaakov Selkowitz 2005-12-01 02:42:03 UTC
Version details: 2.12.0.1

I'm attaching a patch which fixes a few issues building libgnome-2.12.0.1 on Cygwin.
Comment 1 Yaakov Selkowitz 2005-12-01 02:42:45 UTC
Created attachment 55455 [details] [review]
libgnome-2.12.0.1 Cygwin patch
Comment 2 Kjartan Maraas 2006-01-01 21:57:57 UTC
Is this relevant for 2.13.x too?
Comment 3 Yaakov Selkowitz 2006-01-03 00:07:25 UTC
This is all build-system related, and I didn't see any relevant changes to the affected files in ViewCVS.
Comment 4 Kjartan Maraas 2006-01-11 15:29:20 UTC
Sorry, I should have been clearer. The reason I asked was that the patch didn't apply cleanly.
Comment 5 Yaakov Selkowitz 2006-01-11 21:55:41 UTC
Created attachment 57179 [details] [review]
libgnome-2.13 Cygwin patch

OK, I think I see the problem; the gnome-vfs-2.0 requirement is no longer conditional, even on MinGW.[1]  Please try this.

[1] http://cvs.gnome.org/viewcvs/libgnome/configure.in?r1=1.218&r2=1.219
Comment 6 Kjartan Maraas 2006-01-15 16:44:38 UTC
This is what I get on HEAD:

[kmaraas@localhost libgnome]$ patch -p1 < ~/libgnome2-2.12.0.1-1.patch
patching file configure.in
Hunk #1 FAILED at 69.
1 out of 1 hunk FAILED -- saving rejects to file configure.in.rej
patching file monikers/GNOME_Moniker_std.server.in.in
patching file monikers/Makefile.am
Hunk #1 FAILED at 5.
Hunk #2 succeeded at 32 (offset 7 lines).
1 out of 2 hunks FAILED -- saving rejects to file monikers/Makefile.am.rej
[kmaraas@localhost libgnome]$ rm monikers/Makefile.am.
Makefile.am.orig  Makefile.am.rej
[kmaraas@localhost libgnome]$ vi monikers/Makefile.am.rej
Comment 7 Kjartan Maraas 2006-01-15 16:49:22 UTC
Btw, the monikers/Makefile.am part fails on the gnome-2-12 branch as well. Please do patches against CVS, not tarballs. Thanks for the work though :)
Comment 8 Yaakov Selkowitz 2006-12-06 07:37:28 UTC
Created attachment 77790 [details] [review]
libgnome-2.16.0 patch
Comment 9 Kjartan Maraas 2006-12-06 19:52:11 UTC
Commited. Thanks.