GNOME Bugzilla – Bug 322884
Delete should ask for confirmation
Last modified: 2006-01-09 04:40:05 UTC
Deleting an image can be done by hitting the del key. However this can be done by accident and then the image dissapears in the Trash. Non computer savvy people might not know what happened to them. So my suggestion is to introduce a confirmation dialog
This is intentional. The idea is for EOG to behave like Nautilus. See bug 309046.
Reopening the bug. Let me try to explain why: The patch of bug 30946 was applied before the uber cool patch of bug 310455 of Lucas landed in CVS. The patch of bug 310455 killed the thumbnail. I agree that in the thumbnail view not having a confirmation dialog was the best choice, but the way eog currently works (which IMHO is a lot better) it will lead to large confusion. If you build eog from CVS and hit the del key the visual feedback you get is that the next image is shown. (Also the image is deleted but is not clear, the only thing you notice is that the total image count in the status bar goes down) In the worst case people might think that the del key is equal to next image. And after they watched all the images, all there images are gone. Or by accident they hit the del key once without noticing it when showing the pictures to a friend and couple of months later they want to see the pictures again and then one of the pictures is gone. They maybe already emptied the trash in the meantime. So I hope you agree that we really need a confirmation dialog. So my suggestion is the following 1. Edit -> Delete should be renamed to Edit -> Move to Trash (Nautilus also uses Move to Trash ) 2. A dialog should popup. Proposal: * Dialog with not title. * Question mark icon * Are you sure that you want to move "xxxxx.jpg" to the trash? * Cancel button * Move to Trash button I agree with the comment in bug 30946 that the original dialog is not OK
Created attachment 55657 [details] [review] Patch * Renames "Delete" to "Move to Trash" * To protect the user against accidently deleting his images by pressing the delete key it shows a confirmation dialog when the Delete key is pressed. When selecting Move to Trash from the menu no confirmation dialog is shown.
Created attachment 55658 [details] screenshot of the confirmation dialog
Ok Jaap, seems fair enough. I agree that with the current UI, it can get confusing having no confirmation for deletion. Also, the proposed dialog looks nice and coherent. Applied in HEAD with some code fixes and refactoring. Thanks! 2005-01-09 Lucas Rocha <lucasr@gnome.org> * shell/eog-gtk-ui.xml, shell/eog-window.c: new delete confirmation dialog that only appears when using Del accel to remove an image (Fixes bug #322884). Patch from Jaap A. Haitsma <jaap@haitsma.org> with some fixes and refactoring.