After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 322856 - [mpeg2dec] Use of wrong variables
[mpeg2dec] Use of wrong variables
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
git master
Other Linux
: Normal normal
: 0.10.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-11-30 16:30 UTC by Josef Zlomek
Modified: 2005-12-21 10:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch (854 bytes, patch)
2005-11-30 16:30 UTC, Josef Zlomek
committed Details | Review

Description Josef Zlomek 2005-11-30 16:30:30 UTC
Fucntion normal_seek uses wrong variables passed to gst_mpeg2dec_sink_convert.
First normal_seek wants to convert format to GST_FORMAT_TIME and sends this event.
If sending fails, it wants to convert format to GST_FORMAT_BYTES, but because of
the buf it converts it back to the original format.

The attached patch fixed the second target format.
Comment 1 Josef Zlomek 2005-11-30 16:30:57 UTC
Created attachment 55432 [details] [review]
Patch
Comment 2 Tim-Philipp Müller 2005-12-21 10:00:49 UTC
It's in CVS now:

2005-12-21  Josef Zlomek  <josef dot zlomek at xeris dot cz>

       * ext/mpeg2dec/gstmpeg2dec.c: (normal_seek):
         Really convert to BYTES format when we want to convert
         to bytes (use right variable; fixes #322856).

Thanks for the patch and sorry it took so long to get it in.