After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 322593 - Add Return (Next Image); Shift SpaceBar, Shift Return (Previous) accelerators
Add Return (Next Image); Shift SpaceBar, Shift Return (Previous) accelerators
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-11-27 20:57 UTC by Jaap A. Haitsma
Modified: 2005-12-01 18:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (4.69 KB, patch)
2005-11-27 21:01 UTC, Jaap A. Haitsma 		none Details | Review

Description Jaap A. Haitsma 2005-11-27 20:57:12 UTC 
patch coming up
Comment 1 Jaap A. Haitsma 2005-11-27 21:01:11 UTC 
Created attachment 55292 [details] [review]
Patch

Patch adds accelerators
Return for Next Image
Shift Return and ShiftSpaceBar for Previous Image

Evince also has these accelerators

Furthermore it refactors the verb_GoPrev_cb function in 4 more simple
functions.
This way if you want to introduce an extra accelator you won't have to edit the
verb_GoPrev_cb function.
Comment 2 Lucas Rocha 2005-12-01 03:52:42 UTC 
Nice catch, nice refactoring. Applied, thanks!
Comment 3 Jaap A. Haitsma 2005-12-01 18:08:10 UTC 
Thanks for applying this Lucas. Could you also take a look at the shortcut keys
patch at bug 310455 ? That basically contains this patch + a number of shortcut
key rearangements
Thanks