GNOME Bugzilla – Bug 322567
GtkOptionMenu should be replaced by GtkComboBox
Last modified: 2005-12-12 09:28:24 UTC
Patch coming up
Created attachment 55279 [details] [review] Patch * Changes GtkOptionMenu to GtkComboBox * Also gives GDK_WINDOW_TYPE_HINT_DIALOG to the dialog There's one wacky thing in my patch. In synch_[group|user]_combo_box the contents of the combo_box need to be cleared. <snip> + /* Clear the contents of ComboBox in a wacky way because there + * is no function to clear all items and also no function to obtain + * the number of items in a combobox. + */ + model = gtk_combo_box_get_model (combo_box); + g_return_if_fail (GTK_IS_LIST_STORE (model)); + store = GTK_LIST_STORE (model); + gtk_list_store_clear (store); </snip> I don't see a better way to do this. Maybe somebody else does? IMO a clear function and a function to get the number of elements in a combobox are handy. Should I write a patch for GtkComboBox?? This patch also fixes bug 322539
Created attachment 55586 [details] [review] Patch for last instance in nautilus where optionmenu was used This patch also changes the optionmenu used in the browser window
I started looking at the first patch. I think it needs to ref the file to make sure it doesn't go away. This used to be done in the FileNamePair, but isn't done now.
I commited the second patch. Review comments for first patch at: http://mail.gnome.org/archives/nautilus-list/2005-December/msg00024.html
Created attachment 55842 [details] [review] Patch updated according to Alex his comments
Commited.