After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 322366 - Import existing data from gthumb
Import existing data from gthumb
Status: RESOLVED WONTFIX
Product: f-spot
Classification: Other
Component: General
CVS
Other Linux
: Normal enhancement
: ---
Assigned To: F-spot maintainers
F-spot maintainers
gnome[unmaintained]
Depends on:
Blocks:
 
 
Reported: 2005-11-24 22:46 UTC by Ben Parsons
Modified: 2018-07-12 00:00 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
Patch for automatically importing gthumb metadata when importing photos (12.12 KB, patch)
2006-02-24 20:57 UTC, Gabriel Burt
none Details | Review
Fixed patch so it applies against CVS (11.38 KB, patch)
2006-05-24 02:28 UTC, Bengt Thuree
none Details | Review
Patch against CVS with Delete of tags on cancel (11.92 KB, patch)
2006-05-26 06:22 UTC, Bengt Thuree
none Details | Review
Patch against CVS with Delete of tags on cancel (13.96 KB, patch)
2006-05-31 09:47 UTC, Bengt Thuree
none Details | Review
Updated patch against cvs (14.93 KB, patch)
2006-09-02 13:10 UTC, Bengt Thuree
none Details | Review
Patch to import GThumb Metadata (14.16 KB, patch)
2006-10-15 06:24 UTC, Bengt Thuree
none Details | Review
Patch to import GThumb Metadata (15.64 KB, patch)
2006-10-16 12:27 UTC, Bengt Thuree
none Details | Review

Description Ben Parsons 2005-11-24 22:46:13 UTC
Title says it all, I've got a lot of data in gthumb format, not too willing to
change apps without an easy transfer.
Comment 1 Larry Ewing 2006-01-09 07:19:34 UTC
how does gthumb save the data?
Comment 2 Gabriel Burt 2006-02-22 08:04:52 UTC
I have a patch made for this that Larry is reviewing.
Comment 3 Gabriel Burt 2006-02-24 20:57:20 UTC
Created attachment 60079 [details] [review]
Patch for automatically importing gthumb metadata when importing photos
Comment 4 Bengt Thuree 2006-05-24 02:28:26 UTC
Created attachment 66105 [details] [review]
Fixed patch so it applies against CVS

This patch do not apply cleanly anymore

Fixed the patch, so it cleanly applies to CVS again.

Wondering why "imported_photos = null;" is set to null in Finish in FileImportBackend.cs though, since it is not in CVS. 

Tested it, and it runs nicely. Seems like something we definitely should commit fairly soon.
Have anyone else also tested/verified this one?
Comment 5 Bengt Thuree 2006-05-25 15:11:22 UTC
I can not see that the patch removes the just created tags, if the user cancels?
The tags are stored in tags_created, but this one is never used.
Comment 6 Bengt Thuree 2006-05-26 06:22:11 UTC
Created attachment 66245 [details] [review]
Patch against CVS with Delete of tags on cancel

Just added a small Cancel to GthumbImporter which handles remove of created tags.
Comment 7 Bengt Thuree 2006-05-29 03:35:16 UTC
Apparently there is a small crash introduced with the last patch, if you do the following:

1) open a folder that contains GThumb meta data
2) DO NOT IMPORT
3) Open another folder
4) --> Crash

Comment 8 Bengt Thuree 2006-05-31 09:47:26 UTC
Created attachment 66516 [details] [review]
Patch against CVS with Delete of tags on cancel

Had to disable the DisplayTags in ImportCommand since apparently Cancel do not clean up everything good enough.
Comment 9 Bengt Thuree 2006-08-15 12:23:56 UTC
Perhaps this one should be done as a plugin?
That is, as soon as we have the hooks for it.
Comment 10 Boris Goldowsky 2006-09-02 01:08:55 UTC
The code has changed out from under this patch again - I wasn't able to get it to work properly with current CVS.

I do wish this could work so that I could switch my photo library over.  I'm sure I'm not the only one for whom re-tagging everything manually is intractable.



Comment 11 Bengt Thuree 2006-09-02 13:10:14 UTC
Created attachment 72075 [details] [review]
Updated patch against cvs

Just updated the patch so it applies cleanly against cvs.
(possible problem with the Changelog though)

I still think this patch should be done as a plug-in
Comment 12 Boris Goldowsky 2006-09-04 21:10:01 UTC
Thank you Bengt!

I compiled this in and it does work - now I can convert over all my old photos.

I'm sure there may be more elegant ways to do it, as a plugin or what have you -- but perhaps it's better to have some support that can be improved later, rather than none?

Comment 13 Bengt Thuree 2006-10-15 06:24:59 UTC
Created attachment 74744 [details] [review]
Patch to import GThumb Metadata

Updated patch to import GThumb Metadata.

probably needs some work to fit in more with the existing XMP import.
Also, the newly created tags should end up under Last Imports.
Comment 14 Bengt Thuree 2006-10-16 12:27:11 UTC
Created attachment 74802 [details] [review]
Patch to import GThumb Metadata

Here is an updated patch
No more dialog window. If there are metadata, lets import it.
I moved some code from XmpTagsImporter.cs to TagsImporter, and made XmpTagsImporter and GthumbsTagsImporter.cs inherit it.

Comments/Review anyone?
Comment 15 Bengt Thuree 2007-03-14 13:00:30 UTC
Any thoughts of getting this one into SVN?
Since a lot of people probably used gthumb to create tags I mean...
Comment 16 Andrea 2007-07-31 14:15:04 UTC
Are there any news about this? I don't think the last patch works anymore. Will it ever get into the main trunk?
Comment 17 Ulf Rompe 2008-01-15 21:13:57 UTC
Shameless plug: In the meantime, if someone want's to switch from GThumb to F-Spot, there's the exiflow project ( http://exiflow.sf.net/ ) that (for example) creates EXIF tags based on GThumb metadata. After running the software, you can import your photos the normal way into F-Spot and have your tag list created automatically since F-Spot converts EXIF keywords to tags on import.
Comment 18 Ruben Vermeersch 2010-06-24 14:19:33 UTC
Comment on attachment 74802 [details] [review]
Patch to import GThumb Metadata

This won't work anymore with the new import, but it should be *much* easier to add an importer for gthumb, in a clean and pretty way.
Comment 19 André Klapper 2018-07-12 00:00:33 UTC
F-Spot has moved to https://github.com/f-spot/f-spot/issues

If this Bugzilla ticket is still valid in a recent version of F-Spot, please feel free to post this topic as a ticket in the F-Spot project on GitHub.

Closing this report as WONTFIX as part of Bugzilla Housekeeping as we are planning to shut down GNOME Bugzilla in favor of GNOME Gitlab.