After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 322310 - compose crashes when selecting HSV
compose crashes when selecting HSV
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Plugins
2.3.x
Other Windows
: Normal normal
: 2.4
Assigned To: GIMP Bugs
GIMP Bugs
: 337447 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-11-24 09:18 UTC by Pete Wilson
Modified: 2008-01-15 14:05 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Pete Wilson 2005-11-24 09:18:16 UTC
Distribution/Version: XP SP2

Open JPG 1600x1200 Image. Do Color|Components|Decompose..., select HSV and OK.

Do Colors|Components|Compose..., select HSV and get Plug-In crashed "compose.exe"
Comment 1 Pete Wilson 2005-11-24 09:19:08 UTC
Note: Unsharp mask help documentation recommends decompose/compose process.
Comment 2 Michael Schumacher 2005-11-25 13:39:54 UTC
I can't reproduce this.
Comment 3 Pete Wilson 2005-11-26 22:51:35 UTC
I have tried some additional tests - I created a new, RGB document, decomposed
HSV to layers, then tried to compose HSV. Same crash.
Comment 4 weskaggs 2005-11-28 17:09:56 UTC
I also can't reproduce, using cvs HEAD in Linux.  A couple of questions:  

1) Does the crash come after you press the "okay" button, or right after you
select "HSV" from the menu?

2) You *are* running Compose from the image that results from Decompose, right?

Also, it might be worth trying the "Recompose" command -- a new version that
automatically recombines the layers in the way that they were decomposed, and
replaces the originally decomposed layer with the result.  It would be
interesting to know whether it crashes in the same way.
Comment 5 Pete Wilson 2005-12-27 05:38:35 UTC
1) Immediately after clicking HSV in the drop-down.
2) File|New|Ok. Colors|Components|Decompose; HSV; OK. Colors|Components|Compose; HSV - crash.

Recompose does not crash and seems to recompose properly.

Note: Re-installed PC due to different issue - new install of Windows XP, SP2, Gimp 2.3.5, later video drivers - still crashes.
Comment 6 Michael Schumacher 2005-12-27 10:11:31 UTC
That makes it a really weird error - and the question asked for all weird errors in GIMP on Windows nowadays is: do you have GAIM and its GTK+ installed? 

And if so, before you installed GIMP (then the GIMP installer is supposed to warn about it) or afterwards?
Comment 7 Pete Wilson 2005-12-27 22:47:04 UTC
No GAIM, no special GTK  - I rebuilt the PC, installed GTK+ 2.8.7 and GIMP 2.3.5.
Comment 8 Michael Schumacher 2006-04-04 00:49:41 UTC
There are more recent version of both GIMP and GTK+ now - anything different?
Comment 9 Sven Neumann 2006-04-06 08:50:00 UTC
Fixed in CVS (thanks to valgrind):

2006-04-06  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/compose.c: add layers in the expected order.

	* plug-ins/common/decompose.c: fixed out-of-bounds access to layer
	array (bug #322310).
Comment 10 Sven Neumann 2006-04-06 08:50:11 UTC
*** Bug 337447 has been marked as a duplicate of this bug. ***
Comment 11 Pete Wilson 2006-05-03 03:32:58 UTC
FYI: GIMP 2.3.8 still crashes using GTK+ 2.8.15
Comment 12 Michael Schumacher 2006-05-03 09:07:23 UTC
Ah, I finally can reproduce this - you're trying the compose on the same image you did decompose, not the newly created one, right?
Comment 13 weskaggs 2006-05-20 20:53:32 UTC
I don't understand comment #12, because "decompose" is only available in RGB images, while "compose" is only available in Grayscale images -- it should be impossible to try "compose" on the same image that was decomposed.  Does it not work like this for you?
Comment 14 Pete Wilson 2006-05-22 18:48:01 UTC
I don't understand #12 either - that is not the problem I am having...
Comment 15 Sven Neumann 2006-06-27 19:02:35 UTC
Crashes are bad and should be fixed before the release. But if we cannot reproduce the crash, I am afraid there is not much we can do about it.
Comment 16 Pete Wilson 2006-06-27 23:27:37 UTC
I installed Gimp 2.3.9 on my work PC (Windows XP SP2) and get the same crash.

I will try to download and compile source so I can debug compose.exe if I can get the time.
Comment 17 Mukund Sivaraman 2006-09-09 11:38:41 UTC
Pete, do you see any messages about what caused the plug-in to crash?
Check also if the error is not something like in bug #316645.

Comment 18 Pete Wilson 2006-09-11 21:45:14 UTC
I am not sure what you mean about any messages. I can try to post more details about crash, however.

After I rebuilt PC, I had no Delphi software knowingly installed, as I tested this almost immediately. I have probably added some since then (I use Delphi 5).

Comment 19 MWH 2006-09-26 23:16:36 UTC
I recently encountered this bug, and will add some additional information.  Hopefully it will be helpful.

First, the crash described here happens to me when choosing selections other than HSV.  It also occurs with CMY, CMYK and LAB, but not with RGBA.  I've not yet tried the other selections (my computer is overheating from the repeated crashes)

For me, the crash occurs as described at times, when first selecting an item from the drop down, but at other times does not occur until pressing the "OK" button.  The difference seems to be whether other operations have been done prior to using this plugin, other than decompose.

I also noticed that after the crash, it is not possible to close the image window itself, but the main GIMP window must be closed.

Finally, I noticed something odd with the menu selections under Components.  If I open an image, do a Decompose to HSV, and immediately close the newly created image, the menu selections on the original image are normal.  However, if I open an image, do Decompose to HSV, select "Compose" on the new image window, then CANCEL that operation before making any drop down selection, THEN close the HSV image window, then the selections under Colors>Components in the original image window are grayed out in just the opposite way they should be.  In other words, the Compose and Recompose are active, and the Channel Mixer and Decompose selections are grayed out, even though this is the original image and neither compose nor recompose will actually work with it.

I am using Windows XP SP2, GIMP 2.3.11 and GTK 2.8.18, the latest available for download from Sourceforge.  I do not have GAIM or any other software that uses GTK installed.

Comment 20 Michael Schumacher 2006-12-21 15:45:28 UTC
Just tried again with current CVS - I can't reproduce this. I wonder if this is a problem in Jernej's builds.
Comment 21 Jan Pernica 2007-01-08 15:14:18 UTC
Crash with Compose CMYK (win XP SP2, Gimp 2.3.12, GTK 2.10.6, OK with Gimp 2.2.13
Comment 22 Jan Pernica 2007-01-09 19:41:04 UTC
I took compose.exe from the version 2.2.13 and placed into 2.3.12. It works fine now.
Comment 23 Jan Pernica 2007-01-25 08:09:42 UTC
It is OK in 2.3.14. I have compiled it for windows and it runs very well.
Comment 24 Sven Neumann 2007-01-25 08:22:54 UTC
Then the culprit was most probably the call to gtk_image_set_from_stock() with a NULL stock ID. That seemed to work well on Linux but apparently caused a crash on Windows. Anyway, closing as FIXED.