After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 322162 - Desktop file improvements
Desktop file improvements
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Movie player
unspecified
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2005-11-22 18:57 UTC by Matthias Clasen
Modified: 2008-10-07 13:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (510 bytes, patch)
2005-11-22 18:58 UTC, Matthias Clasen
rejected Details | Review

Description Matthias Clasen 2005-11-22 18:57:58 UTC
...we will use totem as the default app for movies in FC5, and default apps
should not have the brand name in the menu. Having a generic name in the
.desktop file will make that much easier, since we can just use
desktop-file-install to copy the generic name.
Comment 1 Matthias Clasen 2005-11-22 18:58:51 UTC
Created attachment 55099 [details] [review]
patch
Comment 2 Bastien Nocera 2005-11-23 19:00:05 UTC
Is HEAD good enough? Or does this need to be in gnome-2-12, thus breaking the
freeze?
Comment 3 Matthias Clasen 2005-11-23 21:02:17 UTC
HEAD is good enough for our purposes
Comment 4 Bastien Nocera 2005-11-23 21:18:43 UTC
Committed to HEAD, thanks.

2005-11-23  Bastien Nocera  <hadess@hadess.net>

        * data/totem.desktop.in.in.in: Totem is the default GNOME media player
        so no need to say its name, patch by Matthias Clasen
        <mclasen@redhat.com> (Closes: #322162)
Comment 5 Gabriel Burt 2007-10-03 21:10:43 UTC
Does FC not follow the GNOME HIG, which says "In the menu item name, include a description of functionality in addition to the proper name of the application."?

The HIG gives an example of Epiphany, saying that it should be "Epiphany Web Browser" not just "Epiphany" (and presumably not just "Web Browser", since the fdo spec says the Name field should be the "Specific name of the application").

I think the Name should be "Totem Movie Player" and the GenericName should be "Movie Player".

Matthias, you seemed to suggest that as long as there was a such a GenericName your needs would be met?
Comment 6 Philip Withnall 2007-11-25 14:18:02 UTC
(In reply to comment #5)
> I think the Name should be "Totem Movie Player" and the GenericName should be
> "Movie Player".

+1. We also might want to consider adding:

X-GNOME-DocPath=totem/totem.xml
X-GNOME-Bugzilla-OtherBinaries=totem-video-indexer;totem-video-thumbnailer;totem-audio-preview;
Comment 7 Bastien Nocera 2007-11-25 14:44:09 UTC
(In reply to comment #6)
> (In reply to comment #5)
> > I think the Name should be "Totem Movie Player" and the GenericName should be
> > "Movie Player".
> 
> +1.

I'm sorry Philip, but you don't get to take that sort of decision, especially when I've rejected the patch in the past.

Revert this patch ASAP.
Comment 8 Bastien Nocera 2007-11-25 14:52:30 UTC
Never mind, I got confused by a patch being marked as committed.

(In reply to comment #5)
> Does FC not follow the GNOME HIG, which says "In the menu item name, include a
> description of functionality in addition to the proper name of the
> application."?
> 
> The HIG gives an example of Epiphany, saying that it should be "Epiphany Web
> Browser" not just "Epiphany" (and presumably not just "Web Browser", since the
> fdo spec says the Name field should be the "Specific name of the application").
> 
> I think the Name should be "Totem Movie Player" and the GenericName should be
> "Movie Player".

GenericName isn't implemented in gnome-menus, or the panel. See also:
https://bugzilla.redhat.com/show_bug.cgi?id=293861

> Matthias, you seemed to suggest that as long as there was a such a GenericName
> your needs would be met?

Totem is the default Movie Player for the GNOME Desktop, and just like the default GNOME calculator doesn't say "gcalctool Calculator", Totem doesn't mention its own name in the UI apart from the about box.
Comment 9 Gabriel Burt 2007-11-26 15:49:49 UTC
Bastien, I respectfully disagree with your conclusion.  I understand that the GenericName isn't used in gnome-menus etc, but many other default applications do not put their GenericName as their Name, eg:

Tomboy Notes
Epiphany Web Browser
GIMP Image Editor
OpenOffice.org Writer
Rhythmbox Music Player
Pidgin Internet Messenger
Firefox Web Browser

The GNOME HIG gives three formats [1] for names:

2.1.1.3. Menu name formats
  1. If your application's proper name is already descriptive of its functionality, and not just suggestive, use the format: Application Name

  2. If there is a succinct functional description of your application, use the format: ApplicationName FunctionalDescription

  3. A few applications, particularly games, do not have appropriate functional descriptions (but note that many games do). In this case, use Application Name as the menu name.

I don't see how using "Movie Player" as the Name is justified by any of these.  #1 and #3 are not applicable, so it should be #2: "Totem Movie Player".

With respect to gcalctool using Calculator as its Name, I submit that's because the g stands for GNOME which the HIG says not to include in the name, and Calculator is more succinct than Calculator Tool.

Sorry for reopening this again - I rest my case here, and won't bother you again if you still disagree.

[1] http://library.gnome.org/devel/hig-book/stable/desktop-application-menu.html.en
Comment 10 Alex Hixon 2008-01-26 05:47:04 UTC
Any status on this, or?

I think Gabriel brings up a farily good point. gEdit and gcalc-tool are probably the only two GNOME applcations that don't use their product name directly ("Text Editor" and "Calculator" respectively).

Totem also generally doesn't serve as just a movie player, it plays a lot of multimedia types. I regularly use it to play songs in playlists when I couldn't be bothered opening my music player. Totem itself is fairly flexible, and I don't think by calling it "Movie Player" you should be restricting its usefulness to new users who don't actually know what the player does (if that makes sense?).

The .desktop could optionally be changed by vendors downstream, but I don't think that's really suitable in this instance. 

> Totem is the default Movie Player for the GNOME Desktop, and just like the
> default GNOME calculator doesn't say "gcalctool Calculator", Totem doesn't
> mention its own name in the UI apart from the about box.

as well as the window title bar, and documentation.
Seems a bit weird having it in those places as "Totem Movie Player" but not having the .desktop entry follow the same pattern.
Comment 11 Bastien Nocera 2008-01-28 09:47:08 UTC
Totem is a movie player that can also play music. Totem is as much a music player as Abiword is an IDE. I can certainly remove that last mention of Totem from the UI (I don't deal with documentation at all).
Comment 12 Bastien Nocera 2008-10-07 13:00:01 UTC
2008-09-29  Bastien Nocera  <hadess@hadess.net>

        * data/totem.ui:
        * src/totem.c (update_mrl_label): Use "Movie Player", and
        not "Totem Movie Player" in the UI