After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 322110 - Problems with online states of buddies with multiple accounts
Problems with online states of buddies with multiple accounts
Status: RESOLVED FIXED
Product: gossip
Classification: Deprecated
Component: General
0.9
Other All
: Normal normal
: ---
Assigned To: Gossip Maintainers
Gossip Maintainers
: 368794 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-11-22 09:17 UTC by Keywan Najafi Tonekaboni
Modified: 2006-11-17 17:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
quick fix (3.45 KB, patch)
2006-04-25 17:07 UTC, aurelien
none Details | Review
updated and improved patch (5.59 KB, patch)
2006-11-13 21:49 UTC, Xavier Claessens
committed Details | Review

Description Keywan Najafi Tonekaboni 2005-11-22 09:17:49 UTC
Please describe the problem:
I use gossip from cvs with the capability of managing multiple accounts. I have
to accounts (work and private) and some contacts are subscribed in both
accounts. When I am online with both accounts and then go offline with one of
them, all contacts, which are avaible in both accounts disappear from the
contact list. They are not offline, they aren't anymore avaible

Steps to reproduce:
1. Go online with two jabber accounts at the same moment, which have at one or
more same contacts.  
2. Go offline with one account.
3. Compare the list of avaible contacts


Actual results:
Contacts who are in both accounts disappears

Expected results:
That all contacts of the current online account are avaible.

Does this happen every time?
Yes.

Other information:
Comment 1 Martyn Russell 2005-11-22 10:31:43 UTC
Yea, I have known about this for a while.

The problem is, how do we fix it?

I see 2 ways forward:

1. Separating the list into sections for each account (effectively like we do
grouping, but on an account basis too.

2. Keeping a tab on each contact knowing of they are on n+1 accounts and if so,
dealing with that intelligently. 
Comment 2 Keywan Najafi Tonekaboni 2005-11-22 10:56:46 UTC
I think 2. is much better. I like how gaim dealing with multiple contacts for
one real person. you can expand a contact and drag and drop other contacts
inside. even this happens not automatically, i think this is nicer then have
oversized contact list in psi. 

maybe this could be handled automatically. but i think it's fine, when the
contacts only not disappear :D
Comment 3 aurelien 2006-03-18 22:21:38 UTC
I have been experiencing a problem that I think is related to this one:

I also have two accounts (A and B) with one shared contact (C). When I start a discussion with him it is always launched by the same account on my side (A->C).
When he speaks to my other account (C->B), I get its messages in the same window  but he appears offline (probably as this contact is associated to the account A, not to B). After that, when I reply, he gets the "writing notification" in the same window (B -> C) and the message is sent using my other account (A -> C), thus it appears in a new window for him, leading to some misunderstanding :).

I'm not exactly sure that this is the same bug, but it is probably related, so I don't want to create a new one, at least for now.
Comment 4 aurelien 2006-04-25 17:07:35 UTC
Created attachment 64282 [details] [review]
quick fix

I have a quick fix, after applying it, accounts with the same id but with different contacts appear twice in the contact list, the strange behavior of the online state is gone, and also the "reply using random contact" bug which I found pretty annoying.

I know it is not the intended long term fix but gossip is more usefull this way for me.

hope it helps.
Comment 5 Richard Hult 2006-06-02 17:37:12 UTC
I'm also having some problems with this. I guess the patch could work as a workaround for now, since the "real" fix is a lot more work... (meta-contacts etc).
Comment 6 Richard Hult 2006-08-26 08:04:07 UTC
Note that gossip is working a lot better since a while back since we now always send from the account that we were sent to, not just any one that happened to have the contact in its list.
Comment 7 Xavier Claessens 2006-11-13 21:49:18 UTC
Created attachment 76526 [details] [review]
updated and improved patch

I updated the proposed patch to last CVS and I changed it a bit: To be sure 2 accounts are different I use something based on account's unique_id rather than account's id. See bug #368794.

patch commited to TELEPATHY, ok to commit on HEAD ?
Comment 8 Xavier Claessens 2006-11-13 21:50:29 UTC
*** Bug 368794 has been marked as a duplicate of this bug. ***