After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 322069 - Names of GstTagSetter methods should be more descriptive
Names of GstTagSetter methods should be more descriptive
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.9.x
Other Linux
: Normal normal
: 0.9.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 319388
 
 
Reported: 2005-11-21 20:21 UTC by Torsten Schoenfeld
Modified: 2005-11-22 12:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Adding "tags" and "tag" (5.90 KB, patch)
2005-11-21 20:21 UTC, Torsten Schoenfeld 		committed Details | Review

Description Torsten Schoenfeld 2005-11-21 20:21:02 UTC 
Attached is a patch that adds some "tags" and "tag" to GstTagSetter's method
names to make them more descriptive.  This is mainly benefits language bindings
that hide the prefix gst_tag_setter_.
Comment 1 Torsten Schoenfeld 2005-11-21 20:21:26 UTC 
Created attachment 55047 [details] [review]
Adding "tags" and "tag"
Comment 2 Andy Wingo 2005-11-22 12:20:52 UTC 
2005-11-22  Andy Wingo  <wingo@pobox.com>

	patch by: Torsten Schoenfeld <kaffeetisch gmx de>

	* gst/gsttagsetter.h:
	* gst/gsttagsetter.c: (gst_tag_setter_merge_tags)
	(gst_tag_setter_add_tags, gst_tag_setter_add_tag_values)
	(gst_tag_setter_add_tag_valist)
	(gst_tag_setter_add_tag_valist_values): Renamed from _merge, _add,
	_add_values, _add_valist, and _add_valist_values. Since this is an
	interface the function suffixes should be more explicit so
	language binding don't end up with element.add_valist ->
	gst_tag_setter_add_valist, for example. Fixes #322069.