After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 322001 - unable to display menu item in ja locale
unable to display menu item in ja locale
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: general
2.4.x (obsolete)
Other All
: Normal normal
: ---
Assigned To: Harish Krishnaswamy
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2005-11-21 06:02 UTC by Lawrence Lim
Modified: 2005-12-12 20:03 UTC
See Also:
GNOME target: ---
GNOME version: 2.11/2.12


Attachments
screenshot in ja_JP locale (127.48 KB, image/png)
2005-11-21 06:03 UTC, Lawrence Lim
  Details
screenshot in en_US locale (98.06 KB, image/png)
2005-11-21 06:04 UTC, Lawrence Lim
  Details
Patch to escape the strings; sent to evolution-patches list 2005-12-09 (1.89 KB, patch)
2005-12-09 07:42 UTC, Dave Malcolm
committed Details | Review

Description Lawrence Lim 2005-11-21 06:02:40 UTC
Please describe the problem:
The menu item for switching to mail,contacts,calendar and tasks is missing in
the ja locale but it is displaying OK in en_US locale.

Steps to reproduce:
1.LANG=ja_JP.UTF-8 evolution
2.third item on the menubar (Alt-V)
3.first item in the sub-menu (W)


Actual results:
No option in ja locale

Expected results:
Similar to en_US, which allow the switching between mail, contacts, etc.

Does this happen every time?
YES

Other information:
# LANG=ja_JP.UTF-8 evolution
adding hook target 'source'

(evolution:7156): XML-CRITICAL **: attributes construct error


(evolution:7156): XML-CRITICAL **: Specification mandate value for attribute メール


(evolution:7156): XML-CRITICAL **: attributes construct error


(evolution:7156): XML-CRITICAL **: error parsing attribute name


(evolution:7156): XML-CRITICAL **: attributes construct error


(evolution:7156): XML-CRITICAL **: xmlParseStartTag: problem parsing attributes


(evolution:7156): XML-CRITICAL **: Couldn't find end of Start Tag menuitem line 1


(evolution:7156): XML-CRITICAL **: attributes construct error


(evolution:7156): XML-CRITICAL **: Specification mandate value for attribute 連絡先


(evolution:7156): XML-CRITICAL **: attributes construct error


(evolution:7156): XML-CRITICAL **: error parsing attribute name


(evolution:7156): XML-CRITICAL **: attributes construct error


(evolution:7156): XML-CRITICAL **: xmlParseStartTag: problem parsing attributes


(evolution:7156): XML-CRITICAL **: Couldn't find end of Start Tag menuitem line 1


(evolution:7156): XML-CRITICAL **: attributes construct error


(evolution:7156): XML-CRITICAL **: Specification mandate value for attribute カ
レンダ


(evolution:7156): XML-CRITICAL **: attributes construct error


(evolution:7156): XML-CRITICAL **: error parsing attribute name


(evolution:7156): XML-CRITICAL **: attributes construct error


(evolution:7156): XML-CRITICAL **: xmlParseStartTag: problem parsing attributes


(evolution:7156): XML-CRITICAL **: Couldn't find end of Start Tag menuitem line 1


(evolution:7156): XML-CRITICAL **: attributes construct error


(evolution:7156): XML-CRITICAL **: Specification mandate value for attribute タスク


(evolution:7156): XML-CRITICAL **: attributes construct error


(evolution:7156): XML-CRITICAL **: error parsing attribute name


(evolution:7156): XML-CRITICAL **: attributes construct error


(evolution:7156): XML-CRITICAL **: xmlParseStartTag: problem parsing attributes


(evolution:7156): XML-CRITICAL **: Couldn't find end of Start Tag menuitem line 1


(evolution:7156): Gdk-CRITICAL **: gdk_gc_set_foreground: assertion `GDK_IS_GC
(gc)' failed
Comment 1 Lawrence Lim 2005-11-21 06:03:48 UTC
Created attachment 55007 [details]
screenshot in ja_JP locale

No options available. Notice the empty sub-menu.
Comment 2 Lawrence Lim 2005-11-21 06:04:30 UTC
Created attachment 55008 [details]
screenshot in en_US locale

Original version which allow the switching to different evolution's functions.
Comment 3 Dave Malcolm 2005-11-28 23:27:57 UTC
Problem appears to be bogus XML menu description generated in e-shell-window.c:
setup_widgets()

In po/ja.po this translation:
msgid "Switch to %s"
msgstr "\"%s\" へ切り替えます"

contains quote characters.  These get copied inline into the generated XML ui
description, for the tip attribute without escaping, and this stops it being
well-formed XML; you end up with something of the form:
<menuitem name="SwitchComponent-contacts" verb="" label="foo" accel="bar"
tip=""foobar" へ切り替えます" pixbuf="etc etc" />

Fix appears to be to either escape any control characters in the attribute, or
fix the translation.

Appears to still affect CVS HEAD; might affect other languages.
Comment 4 Dave Malcolm 2005-12-09 07:42:25 UTC
Created attachment 55801 [details] [review]
Patch to escape the strings; sent to evolution-patches list 2005-12-09
Comment 5 Dave Malcolm 2005-12-12 20:03:27 UTC
Patch committed to CVS; should now be fixed for 2.5.3