Bug 321962 – [easyfix] gst_value_is_fixed uses gst_value_list_* on GST_TYPE_ARRAYs

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 321962 - [easyfix] gst_value_is_fixed uses gst_value_list_* on GST_TYPE_ARRAYs


Summary:	[easyfix] gst_value_is_fixed uses gst_value_list_* on GST_TYPE_ARRAYs


Status:	RESOLVED FIXED

Product:	GStreamer
Classification:	Platform
Component:	gstreamer (core)
Version:	git master
Hardware:	Other All

Importance:	Normal normal
Target Milestone:	0.9.6
Assigned To:	GStreamer Maintainers
QA Contact:	GStreamer Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2005-11-20 20:14 UTC by Alessandro Decina
Modified:	2005-11-21 12:37 UTC

See Also:
GNOME target:	---
GNOME version:	2.13/2.14

Attachments
easy fix (428 bytes, patch) 2005-11-20 20:15 UTC, Alessandro Decina	committed	Details \| Review
substitute gst_value_list_append_value with gst_value_array_append_value in gst-plugins-base (6.92 KB, patch) 2005-11-20 21:27 UTC, Alessandro Decina	committed	Details \| Review

Description Alessandro Decina 2005-11-20 20:14:49 UTC

Please describe the problem:
gst_value_is_fixed first checks for GST_VALUE_TYPE (value) == GST_TYPE_ARRAY and
then uses gst_value_list_get_size on the value. That results in an error as
GST_VALUE_HOLDS_LIST (value) called in gst_value_list_get_size fails.

Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:

Comment 1 Alessandro Decina 2005-11-20 20:15:31 UTC

Created attachment 54987 [details] [review]
easy fix

Comment 2 Alessandro Decina 2005-11-20 21:27:48 UTC

Created attachment 54991 [details] [review]
substitute gst_value_list_append_value with  gst_value_array_append_value in gst-plugins-base

Comment 3 Andy Wingo 2005-11-21 12:37:12 UTC

2005-11-21  Andy Wingo  <wingo@pobox.com>

	patch by: Alessandro Dessina <alessandro nnva org>

	* ext/ogg/gstoggmux.c (gst_ogg_mux_set_header_on_caps):
	* ext/ogg/gstoggparse.c (gst_ogg_parse_append_header)
	(gst_ogg_parse_chain):
	* ext/theora/theoraenc.c (theora_set_header_on_caps):
	* ext/vorbis/vorbisenc.c (gst_vorbisenc_set_header_on_caps):
	* ext/vorbis/vorbisparse.c (vorbis_parse_set_header_on_caps): Fix
	gst_value_list calls on arrays. Fixes #321962.

2005-11-21  Andy Wingo  <wingo@pobox.com>

	patch by: Alessandro Dessina <alessandro nnva org>

	* gst/gstvalue.c (gst_value_is_fixed): Use gst_value_array
	functions to access arrays. Fixes #321962.