After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 321952 - [Patch] Setup http_proxy environment variable in gnome-terminal
[Patch] Setup http_proxy environment variable in gnome-terminal
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
2.12.x
Other Linux
: Normal enhancement
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
list-kmaraas
Depends on:
Blocks:
 
 
Reported: 2005-11-20 18:31 UTC by John Spray
Modified: 2006-01-16 19:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fill the http_proxy environment variable from gconf settings on startup (1.35 KB, patch)
2005-11-20 18:35 UTC, John Spray
none Details | Review
Neater, and actually works (1.58 KB, patch)
2005-11-20 18:46 UTC, John Spray
committed Details | Review

Description John Spray 2005-11-20 18:31:37 UTC
Most command line applications run from a gnome-terminal wouldn't know anything
about the user's GNOME proxy settings - the user would have to set up the
http_proxy environment variable manually for wget, etc to work.

gnome-terminal could fill the http_proxy environment variable from the gconf
proxy settings when it starts up.
Comment 1 John Spray 2005-11-20 18:35:05 UTC
Created attachment 54981 [details] [review]
Fill the http_proxy environment variable from gconf settings on startup


This patch takes the http proxy settings from /system/http_proxy/ and exports
the http_proxy environment variable on startup.

This shouldn't interfere with anything else, because:
 - If http_proxy is already set then it isn't changed
 - If http_proxy is set in the user's .bashrc then that setting will override
this one

Caveats:
 - This environment variable will get out of date if the GNOME proxy settings
change while gnome-terminal is running.  The nature of environment variables
prevents anything being done about this afaik.
 - If the user is using an automatic configuration URL for their proxy, then
this code will not understand it.  The same goes for a lot of other GNOME
software, this is not a problem unique to this patch.
Comment 2 John Spray 2005-11-20 18:46:30 UTC
Created attachment 54982 [details] [review]
Neater, and actually works

Previous patch had a typo in the gconf key, sorry.
Comment 3 Olav Vitters 2005-11-20 21:37:25 UTC
Nice idea! I know there was a request somewhere to do this in gnome-session (or
some other low layer), but that would always have problems with not being able
to change the environment variable later on. Because of that this makes more
sense (easier to restart one app). I'm not a maintainer though.
Comment 4 Guilherme de Siqueira Pastore 2006-01-16 19:20:42 UTC
I have committed this without checking because of the feature freeze. I will check it and perhaps clean/fix/whatever it if necessary in approximately 6 or 7 hours, when I'm back.

Thanks!