GNOME Bugzilla – Bug 321928
Pre-defined date ranges
Last modified: 2007-07-24 03:24:06 UTC
Would be nice to have a set of pre-defined date ranges like below: * Today * Yesterday * Last 7 days * Last 30 days * Last 90 days * Last 360 days * Current month * Previous month * Current year * Previous year * Current week * Previous week * Customized range
Created attachment 54972 [details] [review] Patch Created a small patch for this. It adds a combo box to the DateRange dialog /Bengt
Created attachment 54973 [details] Screenshot of this patch A small screenshot of the combobox in action
Created attachment 55016 [details] [review] Patch against CVS Fixed some bugs...
Created attachment 55838 [details] [review] Patch against cvs Added option for All Dates.
Created attachment 56343 [details] Screenshot Current and Previous YEAR is replaced with "2005" and "2004" Current and Previous MONTH is replaced with "December" and "November", or if the year is different, "January, 2005", "December, 2004"
Created attachment 56345 [details] [review] Patch Patch against 0.1.5 This patch incorporates presents Current and Previous Year/Month as in the last Screenshot
What remains to be done to get this one into CVS? I have looked a bit on having a drop down box on the main gui, but not sure where to put it to be honest. Any comments?
Ok, I repeat the above question. What remains to be done to get this one into CVS? I have looked a bit on having a drop down box on the main gui, but not sure where to put it to be honest. Any comments?
Patch review: 56345 Patch cleanly against current CVS. It could be useful, clearly. I only see one minor issue... there are no default in the dropdown list. It's a bit confusing at first use. And it's not very user friendly. A good default could be "custom" or "last week". Speaking of usability, I guess that 'last year' is better than 'last 360 days', and 'Previous Week (mon-sun)' could be replaced by 'Previous week (8-14 May)'... my 2 cents, for what it's worth
Last 360 days is : Today is May 20 2006, which means last 360 days is May 21 2005 - May 20 2006 or something like that (todays date - 360 days) I for one is always a bit uncertain of dates... unless I have a calender infront of me. Therefore the Mon - Sun bit. I can try to put in a default as Last 30 days ? (a bit more than 7 days, but not to much more) Thanks for the comments. There is one more thing missing with this patch. There should be an indication on the main gui which daterange we are using. Perhaps even a dropdown field. I would like to get some hints and tips on where to put it, or perhaps someone else would like to do it?
Created attachment 65873 [details] [review] Patch with Default last 7 days This patch is the same as previous one. But it defaults to Last 7 days, and OK button is enabled. Remains (but could be a new bug perhaps) to put an indication (pulldown) on Main GUI
Created attachment 66053 [details] Main UI: date range indicator Check the attached screenshot first. There is already a date range indicator on the Main UI, but nobody uses it. You can select a daterange by moving the left and right 'borders' of the timeline. BTW, when you choose 'Clear Date Range', the timeline is not updated. When you select a date range with the 'Find' menu, the timeline is not updated. I'll create another bug for this.
Give a look at this one #342694
Created attachment 70012 [details] [review] Patch with default last 7 days Uploaded a version of this patch that applies cleanly to CVS. I am not certain if there was more work to be done on this patch or not. Would appreciate some feedback on it:)
> Would appreciate some feedback on it:) Patch review: patch #70012 for bug #321928 pros: *) apply and compile *) nice default (7 days) minor issues: *) needs more vertical spacing (between Select Period and Start Date) *) needs horizontal spacing between 'Select Period' and dropdown list *) Start Date and Select Period needs to be unified (bold ?) *) the left of 'Select Period' and 'Start Date' needs to be aligned *) when you change the selection in the dropdown, the DateTime widgets have to be updated *) don't disable the DateTime widgets, but when they're manually changed, change the dropdown to 'Custom' bug: *) this version re-introduce bug #344314
patch review: continued... in the code, use an enum or an array to store ranges. Create the dropdown from the array (or enum) and make the switch on the same array (or enum). so, you'll sure that everything is consistent.
Created attachment 70031 [details] [review] updated version Eat your own dogfood... I submitted a lot of remarks on Bengt's patch, so I took my part of the job fixing it ;) Bengt updated the UI, I updated the code. Nice team work, again ;) All the issues submitted in comment #15 and comment #16 are now solved. There's still a minor issue, but it will not be a showstopper, since the bug is in Gnome.DateEdit widget: when you do: date_edit.Time = new System.DateTime(2005,1,1); the widget will show 2004/12/31. this problem only happens on Jan 1st.
Created attachment 73202 [details] [review] Updated patch Just updated changelog to add Stephane's name.
I'd much rather do this with something like a logrithmic time slider than a combo box.
Would this work for previous day, week, month or year?
Larry (comment #19), do you mean changing the time adaptor to be logarithmic or a slider in the DateRange dialog ? I'm not sure that a slider will be more accurate than a combo with predefined rules...
Any possibility to get this into SVN? Logaritimisk scale can come later or ?
Created attachment 92042 [details] [review] Updated patch I updated the patch so if applies cleanly, but had to manually fix the glade file, as well as the diff (beacuse of a few 100 glade diffs).
applied in r3232
would it be possible to enhance the main-ui side pane to include the pre-defined date ranges rather than just having tags listed? for example, the side pane list could look like this (similar to the rhythmbox side pane): ----------------- |Taken Dates | |---------------- | * Today | | * Yesterday | | * Last Month | | * Last Year | | * ... | | * Custom | |---------------- |Photo Tags | |---------------| | * Favourites | | * Hidden | | \/ People | | * Family | | * Friends | | * Places | | * ... | ----------------- where the "Custom" selection would launch the current date selection dialog.
Kevin I will create a new Enhancement Bug (459804) for this suggestion, since this bug is closed.