GNOME Bugzilla – Bug 321902
New maximized windows have an extra border
Last modified: 2005-11-21 18:49:41 UTC
I just downloaded metacity 2.13.2 and found the following bug: When opening a new maximized window, it has an extra border on the right. The entire window, including the titlebar, is several pixels narrower on the sides and bottom. The width of the border is equal to the width of an unmaximized border for that side. The border goes away once the window is unmaximized. This bug is probably some kind of weird interaction with the new constraints code.
Created attachment 54956 [details] Screenshot showing the mysterious border
Unfortunately, I can't duplicate. Does this happen for you with other themes? Does it occur only when the window is initially placed and happens to be maximized? Does it happen for all windows that you maximize or only certain ones?
This happens with other themes, too. It only happens for initially maximized windows, but it happens all the time. More information: Metacity seems to think that the window is not maximized. Using the "Unmaximize" command does nothing on the window, but using the "Maximize" command causes the extra borders to go away. Next, when the window is unmaximized, it is the size of all the available space, instead of smaller like it should be. You probably shouldn't worry too hard about this bug. I've been trying out debian experimental recently, so there might be a funny library thing going on. See if anyone else encounters it. (Close as INVALID, maybe)
Oops, I accidentally reversed the order of the meta_window_maximize_internal() and meta_frame_calc_geometry() calls in the constraints code (now in place_window_if_needed(); the same code used to be inside meta_window_constrain()). Thanks for the initially maximized hint. I gotta run now but I'll post a patch later to fix this up...
Created attachment 54993 [details] [review] Compute the frame geometry due to maximization after actually maximizing Could you check and verify that this patch fixes the problem for you? Thanks.
Yes! This works! Thanks a bunch, Elijah.
Committed then, as the patch is simple enough. 2005-11-20 Elijah Newren <newren@gmail.com> * src/constraints.c (place_window_if_needed): compute the frame geometry due to maximization only after actually maximizing. Fixes #321902.
*** Bug 322061 has been marked as a duplicate of this bug. ***