GNOME Bugzilla – Bug 321840
Zoom-to-fit state changes between images in fullscreen mode
Last modified: 2006-11-28 19:00:43 UTC
Version details: cvs-2005-11-18 Distribution/Version: Fedora Core 4 Using cvs (2005-11-18) and zoom-to-fit mode is not retained consistently when changing images in fullscreen mode. (Sometimes it is, but mostly it isn't, and I'm not able to figure out the logic to why it does or doesn't.)
this is intentional: in fullscreen mode is always used the fit-image-if-larger-than-screen mode.
As much as I dislike this feature, I think the zoom behaviour should be consistent between browse mode and fullscreen mode. It was very strange to see such a difference in behaviour because I specifically configured gthumb to keep previous zoom, which it did when browsing, but not in fullscreen. One acceptable way to have different zoom behaviours would be to provide another configurable option. Under the viewer tab, have a zoom setting for browse mode, and one for fullscreen mode. Also, I think the existing behaviour (fit-image-only-if-larger) isn't working properly. Create two images, image 1: 538x435 and image 2: 852x594. Enter fullscreen mode on image 1. Advance to image 2. Hit 'x' to fit to window. Back up to image 1. Note how fit-to-window is retained, even though the image is smaller. Or, similarly: enter fullscreen on image 2. Previous to image 1. Hit 'x'. Advance to image 2. Note how fit-to-window is retained.
This is a regression. Please make fullscreen obey what my preferences are set to. I usually have "Keep Previous Zoom" and I expected that to be used in fullscreen mode. I sometimes have very large bitmaps in high resolution that I _don't_ want resized and the current hard coded setting is very annoying when moving through the pictures. If you disagree please make full screen configureable with similar preferences to regular mode.
Please fix that regression. It ignores user settings, introduces illogical discrepancy between window and fullscreen UI behaviour, and renders the viewer useless for the most important use-case for me: reading scanned manga pages in fullscreen mode, as well as any other type of browsing through image collection where zoom to fit is undesired. Setting severity to major, because it breaks a whole class of existing functionality.
It took me a while to discover why this was working different on an Ubuntu than on my Debian box. Ubuntu is using 2.7 series and I found it very annoying to find that it wouldn't maintain the preference set under viewer. It SHOULD have an extra configuration box for behaviour under fullscreen.
https://launchpad.net/distros/ubuntu/+source/gthumb/+bug/47070 mentions the same problem.
*** Bug 331812 has been marked as a duplicate of this bug. ***
*** Bug 351786 has been marked as a duplicate of this bug. ***
*** Bug 358031 has been marked as a duplicate of this bug. ***
Created attachment 73672 [details] [review] Patch to make fullscreen mode respect zoom preferences The attached patch makes the fullscreen mode respect the zoom preference. The the zoom prefence is "keep previous", the first fullscreen image is zoomed with a "fit-if-larger" mode. If you change the zoom level, the change will persist for the remaining images in the fullscreen series. I think that this makes it look like friendly zoom-to-fit mode for most "newbie" users, while giving "power users" the flexibility they want.
Oops, typo. It should say: The attached patch makes the fullscreen mode respect the zoom preference. If the zoom prefence is "keep previous", the first fullscreen image is zoomed ^^ with a "fit-if-larger" mode. If you change the zoom level, the change will persist for the remaining images in the fullscreen series. I think that this makes it look like friendly zoom-to-fit mode for most "newbie" users, while giving "power users" the flexibility they want.
I've applied with fuzz and tested with version 2.7.7. Patch works as advertised. This probably doesn't mean much, but I disagree with the notion that "keep previous" means do "zoom-if-larger" in full-screen first until notified by the user. This is why the default is "zoom-if-larger". Newbies don't go routing around preferences so they'll get this "feature" by default. If I say "keep-previous", I mean "keep-previous". Just my .0000001 cent. thanks and thanks for the patch.
(In reply to comment #12) > around preferences so they'll get this "feature" by default. If I say > "keep-previous", I mean "keep-previous". Just my .0000001 cent. thanks and > thanks for the patch. What do you want to happen on the first fullscreen image in keep-previous mode? There is no previous image in that situation.
Why was this feature introduced in the first place? Wasn't the desired behavior already present in older versions? I'm almost certain it was in gthumb on Fedora Core 2.
patch applied to CVS, thanks.
*** Bug 380216 has been marked as a duplicate of this bug. ***